Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Dockerfile: remove unnecessary env vars #811

Merged
merged 3 commits into from
Oct 31, 2024
Merged

Update Dockerfile: remove unnecessary env vars #811

merged 3 commits into from
Oct 31, 2024

Conversation

AlvaroVega
Copy link
Member

@AlvaroVega AlvaroVega commented Oct 31, 2024 •
edited
Loading

Comes from #810
Remove the following unnecessary env vars from Dockerfile:

ENV PERSEO_MONGO_HOST=mongodb
ENV PERSEO_CORE_URL=http://corehost:8080

@AlvaroVega AlvaroVega changed the title Update Dockerfile: remove unnecessary env -vars Update Dockerfile: remove unnecessary env vars Oct 31, 2024
@AlvaroVega AlvaroVega requested a review from fgalan October 31, 2024 11:06
@AlvaroVega AlvaroVega marked this pull request as ready for review October 31, 2024 11:06
fgalan
fgalan approved these changes Oct 31, 2024
View reviewed changes
Copy link
Member

@fgalan fgalan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fgalan fgalan merged commit 9aa857e into master Oct 31, 2024
7 checks passed
@fgalan fgalan deleted the task/remove_unnecesarry_env_vars_from_dockerfile branch October 31, 2024 11:33
@fgalan fgalan mentioned this pull request Oct 31, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fgalan fgalan fgalan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AlvaroVega @fgalan