Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not search in entities collection with strict mode #794

Merged
merged 3 commits into from
Jul 22, 2024
Merged

Do not search in entities collection with strict mode #794

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0ab937b
Do not search in entities collection with strict mode
AlvaroVega Jul 19, 2024
aef02fe
Update CHANGES_NEXT_RELEASE
AlvaroVega Jul 19, 2024
aaa02a3
Merge branch 'master' into task/allow_non_entities_collection
fgalan Jul 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGES_NEXT_RELEASE
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1,3 @@
- Fix: do not search in entities collection with strict mode by non_signal checker (#793)
- Fix: do not try cast entity id and entity type in update rules when expand parameters of rule to avoid BadRequest en CB tries to update that entities (#791)
- Fix: do not invoke calback twice when error about trust not found in trustConf (#790)
2 changes: 1 addition & 1 deletion lib/models/entitiesStore.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -151,7 +151,7 @@ function findSilentEntitiesByMongo(service, subservice, ruleData, alterFunc, cal

async.waterfall(
[
db.collection.bind(db, entitiesCollectionName, { strict: true }),
db.collection.bind(db, entitiesCollectionName, { strict: false }),
function(col, cb) {
col.find(criterion)
.batchSize(config.orionDb.batchSize)
Expand Down
Loading