Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow access entities using NGSIv2 API for non_signal rules #726

Merged
merged 87 commits into from
Jul 10, 2023

Conversation

AlvaroVega
Copy link
Member

@AlvaroVega AlvaroVega commented May 30, 2023

test/unit/entitiesStore_utest.js Outdated Show resolved Hide resolved
test/unit/entitiesStore_utest.js Outdated Show resolved Hide resolved
test/unit/entitiesStore_utest.js Outdated Show resolved Hide resolved
@AlvaroVega
Copy link
Member Author

A CNR update should be expected (just add title of the new feature to CHANGES_NEXT_RELEASE file (i.e: https://github.com/telefonicaid/perseo-fe/pull/717/files )

test/unit/nsr_utest.js Outdated Show resolved Hide resolved
@AlvaroVega
Copy link
Member Author

Configuration should be updated to include an explain new flag: https://github.com/telefonicaid/perseo-fe/blob/master/docs/admin/configuration.md

@AlvaroVega AlvaroVega changed the title [WIP] split findSilentEntities by mongo or API [WIP] allow access entities using NGSIv2 API for non_signal rules Jun 27, 2023
CHANGES_NEXT_RELEASE Outdated Show resolved Hide resolved
Copy link
Member

@fgalan fgalan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (although the decrease in coverage of -1% is somehow significative...)

@AlvaroVega
Copy link
Member Author

AlvaroVega commented Jul 6, 2023

Some pagination issues were reported findSilentEntitiesByAPIWithPagination should acumulate page results in each iteration to returnt them instead of callback(null, response.results);

So still no LGTM #726 (review)

@AlvaroVega
Copy link
Member Author

Comparation with just 1 entity:

time=2023-07-07T07:36:08.738Z | lvl=INFO | corr=n/a | trans=n/a | op=initialRefresh | comp=perseo-fe | srv=n/a | subsrv=n/a | msg=findSilentEntitiesByAPI has found 1 entities in (hr): 8.862058 ms

time=2023-07-07T06:32:56.117Z | lvl=INFO | corr=n/a | trans=n/a | op=initialRefresh | comp=perseo-fe | srv=n/a | subsrv=n/a | msg=findSilentEntitiesByMongo has found 1 entities in (hr): 4.493991 ms

@mrutid
Copy link
Member

mrutid commented Jul 10, 2023

LGTM (except coverage), is it ready to merge @RafaelM3?

@RafaelM3
Copy link
Collaborator

@mrutid it's ready to merge

Copy link
Member

@mrutid mrutid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants