-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
allow access entities using NGSIv2 API for non_signal rules #726
Conversation
A CNR update should be expected (just add title of the new feature to CHANGES_NEXT_RELEASE file (i.e: https://github.com/telefonicaid/perseo-fe/pull/717/files ) |
Configuration should be updated to include an explain new flag: https://github.com/telefonicaid/perseo-fe/blob/master/docs/admin/configuration.md |
Co-authored-by: Fermín Galán Márquez <[email protected]>
…aid/perseo-fe into task/non_signal_by_api
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM (although the decrease in coverage of -1% is somehow significative...)
Some pagination issues were reported findSilentEntitiesByAPIWithPagination should acumulate page results in each iteration to returnt them instead of callback(null, response.results); So still no LGTM #726 (review) |
Comparation with just 1 entity: time=2023-07-07T07:36:08.738Z | lvl=INFO | corr=n/a | trans=n/a | op=initialRefresh | comp=perseo-fe | srv=n/a | subsrv=n/a | msg=findSilentEntitiesByAPI has found 1 entities in (hr): 8.862058 ms time=2023-07-07T06:32:56.117Z | lvl=INFO | corr=n/a | trans=n/a | op=initialRefresh | comp=perseo-fe | srv=n/a | subsrv=n/a | msg=findSilentEntitiesByMongo has found 1 entities in (hr): 4.493991 ms |
…aid/perseo-fe into task/non_signal_by_api
LGTM (except coverage), is it ready to merge @RafaelM3? |
@mrutid it's ready to merge |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
#549
https://github.com/telefonicaid/perseo-fe/blob/master/docs/admin/configuration.md)
https://github.com/telefonicaid/perseo-fe/blob/master/bin/perseo#L70