Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use retries and retry_time env vars #610

Merged
merged 2 commits into from
May 10, 2018
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGES_NEXT_RELEASE
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
- Fix: IOTA_MONGO_RETRIES and IOTA_MONGO_RETRY_TIME env vars are now taken into account (previously there were ignored)
- ADD: log mongo error before raise alarm [#577]
- FIX Automatic device provisioning by means of Configuration Group fails due to a bug in findConfigurationGroup function (#544).
- FIX Static attributes seem not supported in Configuration Group provisioning (#550).
Expand Down
8 changes: 6 additions & 2 deletions lib/commonConfig.js
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,9 @@ function processEnvironmentVariables() {
'IOTA_MONGO_HOST',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CNR about this change? Maybe something like this:

-Fix: IOTA_MONGO_RETRIES and IOTA_MONGO_RETRY_TIME env vars are now taken into account (previously there were ignored)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in 82abee6

'IOTA_MONGO_PORT',
'IOTA_MONGO_DB',
'IOTA_MONGO_REPLICASET'
'IOTA_MONGO_REPLICASET',
'IOTA_MONGO_RETRIES',
'IOTA_MONGO_RETRY_TIME'
],
iotamVariables = [
'IOTA_IOTAM_URL',
Expand All @@ -83,7 +85,9 @@ function processEnvironmentVariables() {
'IOTA_MONGO_HOST',
'IOTA_MONGO_PORT',
'IOTA_MONGO_DB',
'IOTA_MONGO_REPLICASET'
'IOTA_MONGO_REPLICASET',
'IOTA_MONGO_RETRIES',
'IOTA_MONGO_RETRY_TIME'
];

for (var i = 0; i < environmentVariables.length; i++) {
Expand Down