Fix: Extra information about partial updates in responses #3499

CHANGES_NEXT_RELEASE

@@ -1,3 +1,4 @@
+- Fix: extra information about partial updates in responses (#3499)
 - Add: json field in httpCustom and mqttCustom subscriptions (#2560)
 - Add: ${service}, ${servicePath} and ${authToken} macros in custom notifications (#4159)
 - Fix: conditions.alterationTypes not working properly when conditions.attributes is used in entityUpdate case (#1494, reopened)

src/lib/apiTypesV2/Attribute.cpp

@@ -125,6 +125,7 @@ void Attribute::fill(const QueryContextResponse& qcrs, const std::string& attrNa
     contextAttributeP = NULL;
     // Look for the attribute by name
 
+    std::string notExistingAtrr;
     ContextElementResponse* cerP = qcrs.contextElementResponseVector[0];
 
     for (std::size_t i = 0; i < cerP->entity.attributeVector.size(); ++i)
@@ -134,11 +135,16 @@ void Attribute::fill(const QueryContextResponse& qcrs, const std::string& attrNa
         contextAttributeP = cerP->entity.attributeVector[i];
         break;
       }
+      else
+      {
+        notExistingAtrr = cerP->entity.id + "-" + cerP->entity.type + " : [" + attrName + "]";
+      }
     }
 
     if (contextAttributeP == NULL)
     {
-      oeP->fill(SccContextElementNotFound, ERROR_DESC_NOT_FOUND_ATTRIBUTE, ERROR_NOT_FOUND);
+      std::string details = std::string("The entity does not have such an attribute: { " + notExistingAtrr + " }");
+      oeP->fill(SccContextElementNotFound, details, ERROR_NOT_FOUND);
     }
   }
 }

test/functionalTest/cases/0989_GET_v2_entity_attribute/GET_v2_entity_attribute_not_found.test

@@ -74,13 +74,13 @@ Date: REGEX(.*)
 02. GET /v2/entities/E1/attrs/NONE
 ==================================
 HTTP/1.1 404 Not Found
-Content-Length: 79
+Content-Length: 99
 Content-Type: application/json
 Fiware-Correlator: REGEX([0-9a-f\-]{36})
 Date: REGEX(.*)
 
 {
-    "description": "The entity does not have such an attribute",
+    "description": "The entity does not have such an attribute: { E1-T1 : [NONE] }",
     "error": "NotFound"
 }
 

test/functionalTest/cases/0997_GET_v2_entity_single_attribute_value/GET_v2_entity_single_attribute_value_not_found.test

@@ -101,12 +101,12 @@ Date: REGEX(.*)
 02. GET /v2/entities/E1/attrs/NONE/value
 ========================================
 HTTP/1.1 404 Not Found
-Content-Length: 79
+Content-Length: 99
 Content-Type: text/plain
 Fiware-Correlator: REGEX([0-9a-f\-]{36})
 Date: REGEX(.*)
 
-{"error":"NotFound","description":"The entity does not have such an attribute"}
+{"error":"NotFound","description":"The entity does not have such an attribute: { E1-T1 : [NONE] }"}
 
 
 --TEARDOWN--

test/functionalTest/cases/1890_attribute_doesnt_exist_in_entity/attribute_doesnt_exist_in_entity.test

@@ -66,13 +66,13 @@ Date: REGEX(.*)
 02. Ask for E1/A2: GET /v2/entities/E1/attrs/A2/value
 =====================================================
 HTTP/1.1 404 Not Found
-Content-Length: 79
+Content-Length: 100
 Content-Type: application/json
 Fiware-Correlator: REGEX([0-9a-f\-]{36})
 Date: REGEX(.*)
 
 {
-    "description": "The entity does not have such an attribute",
+    "description": "The entity does not have such an attribute: { E1-Thing : [A2] }",
     "error": "NotFound"
 }
 

test/functionalTest/cases/2193_v1_reply_to_v2_response_on_error_with_cpr/v1_reply_to_v2_response_on_error_with_cpr.test

@@ -205,13 +205,13 @@ Date: REGEX(.*)
 04. Query E1/A2 in CB, using NGSIv2
 ===================================
 HTTP/1.1 404 Not Found
-Content-Length: 79
+Content-Length: 97
 Content-Type: application/json
 Fiware-Correlator: REGEX([0-9a-f\-]{36})
 Date: REGEX(.*)
 
 {
-    "description": "The entity does not have such an attribute",
+    "description": "The entity does not have such an attribute: { E1-T1 : [A2] }",
     "error": "NotFound"
 }
 

test/functionalTest/cases/2220_entity_not_found/entity_not_found.test

@@ -70,13 +70,13 @@ Date: REGEX(.*)
 02. Query E1/A2, see error
 ==========================
 HTTP/1.1 404 Not Found
-Content-Length: 79
+Content-Length: 97
 Content-Type: application/json
 Fiware-Correlator: REGEX([0-9a-f\-]{36})
 Date: REGEX(.*)
 
 {
-    "description": "The entity does not have such an attribute",
+    "description": "The entity does not have such an attribute: { E1-T1 : [A2] }",
     "error": "NotFound"
 }