Fix: Avoid triggering notification if metadata changes but not the attribute value itself #3727 #4090
Conversation
Conflicts: src/lib/cache/subCache.cpp src/lib/cache/subCache.h src/lib/mongoBackend/MongoCommonSubscription.cpp src/lib/mongoBackend/MongoCommonSubscription.h
|
Thanks for your contribution! As main comment at the present moment: .test cases should be included to cover the functionality developed by this PR. In addition, note that the PR is breaking some existing .test. That shouldn't happen, except in justified cases (in which case, please provide the proper explanation). |
Added test case in https://github.com/telefonicaid/fiware-orion/pull/4090/files#diff-fbc7a73ce9da4fb932ceed7d59dfe48aba94e9aa68b2c633c41bca1e130deb2e
I am looking on it. |
...lf/avoid_triggering_notification_if_metadata_changes_but_not_the_attribute_value_itself.test
Outdated
Show resolved
Hide resolved
...lf/avoid_triggering_notification_if_metadata_changes_but_not_the_attribute_value_itself.test
Outdated
Show resolved
Hide resolved
...lf/avoid_triggering_notification_if_metadata_changes_but_not_the_attribute_value_itself.test
Outdated
Show resolved
Hide resolved
|
Thanks for the recent fixes but it seems that there are .test files still failing... |
I have tried to fix the failing test cases but I didn't found the suitable solution. Could you please suggest what's changes needs to be done. Thanks |
To do so I'd need to do an in deep analysis of the PR, probably downloading your branch in my system and test on it. I'm afraid I cannot do it in the short term... |
|
We shouldn't see this in .test files
It seems to be a wrongly solved merge conflict. Please fix it and let's check what the next step is. |
|
After the merging of PR #4332 this PR needs to be upgrades with |
|
I understand this PR has been closed, as issue #3737 was finally solved in others PRs. @Anjali-NEC thanks anyway! |
Fixed issue #3727