-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simplify Instrument Pane #79
Open
esarver
wants to merge
48
commits into
main
Choose a base branch
from
task/simplify-instrument-list
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Correct issue with refreshing list when instruments went away - Speed up instrument detection by doing everything in "parallel" (coroutines with async await) - Use TDP refresh method for everything
|
This prevents issues with trying to get info from the same instrument over two separate interfaces concurrently.
- This was due to the way Windows deals with process "signalling"
- Update controls to only be available on Enabled and Active/Connected connections
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't useThis is fine for now, Maybe we changekic info
to check for availability of Raw Socket orTCPIP
visa connectionskic info
to work the desired way.Instrument
,Connection
, andInstrumentProvider
Update Connection statuses upon activation to include already active terminalsTerminals are automatically closed upon deactivation