Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify Instrument Pane #79

Open
wants to merge 48 commits into
base: main
Choose a base branch
from
Open

Conversation

esarver
Copy link
Member

@esarver esarver commented Dec 16, 2024

  • Group connection interfaces by instrument serial number (each instrument can have multiple interfaces)
  • Clicking on connection connects to the instrument
  • Interfaces can be in either Active or Inactive state. The inactive state is triggered when the interface does not respond to an info request.
  • Interface status propagates to the containing instrument
  • Instrument information is shown shorthand in the description for the tree item. A more readable format is available when hovering over the instrument
  • Implement existing commands on the instrument only when instrument is in connected state
    • Upgrade FW
    • Rename
    • Reset
  • Don't use kic info to check for availability of Raw Socket or TCPIP visa connections This is fine for now, Maybe we change kic info to work the desired way.
  • Update status when connected to an interface, disabling all interfaces in the Instrument when one interface is connected.
  • Update settings when connecting to a new, manually entered instrument address
  • Separate concerns into Instrument, Connection, and InstrumentProvider
  • Get rid of unnecessary code
  • Update Connection statuses upon activation to include already active terminals Terminals are automatically closed upon deactivation
  • Organize code

- Correct issue with refreshing list when instruments went away
- Speed up instrument detection by doing everything in "parallel" (coroutines with async await)
- Use TDP refresh method for everything
@esarver esarver self-assigned this Dec 16, 2024
@esarver esarver requested a review from a team as a code owner December 16, 2024 19:17
@esarver esarver changed the title Task/simplify instrument list Simplify Instrument Pane Dec 16, 2024
@esarver esarver marked this pull request as draft December 16, 2024 19:27
@esarver
Copy link
Member Author

esarver commented Dec 17, 2024

  • Note to self: Need to push responsibility of checking instrument interface connectability into the Instrument and Connection classes to ensure we aren't checking the same instrument over two interfaces as the same time.

@esarver esarver marked this pull request as ready for review January 15, 2025 03:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant