Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TSP-809 Fix for showing correct model and serial number instead of undefined #52

Merged
merged 3 commits into from
Sep 25, 2024

Conversation

Shreya-GT
Copy link
Contributor

No description provided.

@Shreya-GT Shreya-GT added the bug Something isn't working label Sep 20, 2024
@Shreya-GT Shreya-GT self-assigned this Sep 20, 2024
@Shreya-GT Shreya-GT requested a review from a team as a code owner September 20, 2024 04:46
@esarver esarver changed the base branch from main to release/v0.18.0 September 23, 2024 14:21
@esarver esarver changed the base branch from release/v0.18.0 to main September 23, 2024 14:23
src/resourceManager.ts Outdated Show resolved Hide resolved
@Shreya-GT Shreya-GT requested a review from esarver September 25, 2024 12:44
Copy link
Member

@esarver esarver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Shreya-GT Shreya-GT merged commit b8051b1 into main Sep 25, 2024
10 checks passed
@esarver esarver deleted the bug_fix/TSP-809-Fix-undefined-model-sn-issue branch October 11, 2024 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants