Skip to content

Commit

Permalink
Stack Overflow Exception Fix (#75)
Browse files Browse the repository at this point in the history
There was a stack overflow exception because I missed changing a member
variable name after I added a getter for it.

Additionally: Use the non-incrementing progress bar instead of one that
shows progress since we don't know how long certain steps will take.
  • Loading branch information
esarver authored Nov 20, 2024
1 parent 54a253a commit 51df96b
Showing 1 changed file with 1 addition and 5 deletions.
6 changes: 1 addition & 5 deletions src/resourceManager.ts
Original file line number Diff line number Diff line change
Expand Up @@ -224,7 +224,7 @@ export class KicProcessMgr {
}

public get kicList(): Array<KicCell> {
return this.kicList
return this._kicList
}

/**
Expand Down Expand Up @@ -396,7 +396,6 @@ export class KicCell extends EventEmitter {
.get("dumpQueueOnConnect")
) {
progress.report({
increment: 0,
message: "Dumping data from instrument output queue",
})
Log.info(
Expand Down Expand Up @@ -427,7 +426,6 @@ export class KicCell extends EventEmitter {
}

progress.report({
increment: 37,
message: "Getting instrument information",
})
Log.trace("Getting instrument information", LOGLOC)
Expand Down Expand Up @@ -495,7 +493,6 @@ export class KicCell extends EventEmitter {
}

progress.report({
increment: 10,
message: `Connecting to instrument with model ${_info.model} and S/N ${_info.serial_number}`,
})

Expand Down Expand Up @@ -559,7 +556,6 @@ export class KicCell extends EventEmitter {
Log.trace(`Connected to ${info.trim()}`, LOGLOC)

progress.report({
increment: 53,
message: `Connected to instrument with model ${_info.model} and S/N ${_info.serial_number}`,
})
return new Promise((resolve) => resolve([info, verified_name]))
Expand Down

0 comments on commit 51df96b

Please sign in to comment.