Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

handling blockType parameter for setblock() command #15

Merged
merged 1 commit into from
Dec 11, 2024
Merged

handling blockType parameter for setblock() command #15

merged 1 commit into from
Dec 11, 2024

Conversation

jharajeev55
Copy link
Contributor

handling blockType parameter for setblock() command

fixing node[N].defbuffer1 and node[N].defbuffer2 not available in node configurations

making sure that node[N].execute(), node[N].getglobal() and node[N].setglobal() is only available with node

@jharajeev55
handeling blockType parameter for setblock() command
bee6e53 
fixing node[N].defbuffer1 and  node[N].defbuffer2 not available in node configurations

making sure that node[N].execute(), node[N].getglobal() and
node[N].setglobal() is only available with node
@jharajeev55 jharajeev55 added the enhancement New feature or request label Dec 11, 2024
@jharajeev55 jharajeev55 requested a review from esarver December 11, 2024 14:19
@jharajeev55 jharajeev55 self-assigned this Dec 11, 2024
@jharajeev55 jharajeev55 requested a review from a team as a code owner December 11, 2024 14:19
@github-actions GitHub Actions
Copy link

JSON File Check Results

Test failed for subfolder: /home/runner/work/tsp-toolkit-webhelp-to-json/tsp-toolkit-webhelp-to-json/testResults/2450/\nTest failed for subfolder: /home/runner/work/tsp-toolkit-webhelp-to-json/tsp-toolkit-webhelp-to-json/testResults/2460/\nTest failed for subfolder: /home/runner/work/tsp-toolkit-webhelp-to-json/tsp-toolkit-webhelp-to-json/testResults/2461/\nTest failed for subfolder: /home/runner/work/tsp-toolkit-webhelp-to-json/tsp-toolkit-webhelp-to-json/testResults/2470/\nTest failed for subfolder: /home/runner/work/tsp-toolkit-webhelp-to-json/tsp-toolkit-webhelp-to-json/testResults/2601B-PULSE/\nTest failed for subfolder: /home/runner/work/tsp-toolkit-webhelp-to-json/tsp-toolkit-webhelp-to-json/testResults/2601B/\nTest failed for subfolder: /home/runner/work/tsp-toolkit-webhelp-to-json/tsp-toolkit-webhelp-to-json/testResults/2602B/\nTest failed for subfolder: /home/runner/work/tsp-toolkit-webhelp-to-json/tsp-toolkit-webhelp-to-json/testResults/2604B/\nTest failed for subfolder: /home/runner/work/tsp-toolkit-webhelp-to-json/tsp-toolkit-webhelp-to-json/testResults/2611B/\nTest failed for subfolder: /home/runner/work/tsp-toolkit-webhelp-to-json/tsp-toolkit-webhelp-to-json/testResults/2612B/\nTest failed for subfolder: /home/runner/work/tsp-toolkit-webhelp-to-json/tsp-toolkit-webhelp-to-json/testResults/2614B/\nTest failed for subfolder: /home/runner/work/tsp-toolkit-webhelp-to-json/tsp-toolkit-webhelp-to-json/testResults/2634B/\nTest failed for subfolder: /home/runner/work/tsp-toolkit-webhelp-to-json/tsp-toolkit-webhelp-to-json/testResults/2635B/\nTest failed for subfolder: /home/runner/work/tsp-toolkit-webhelp-to-json/tsp-toolkit-webhelp-to-json/testResults/2636B/\nTest failed for subfolder: /home/runner/work/tsp-toolkit-webhelp-to-json/tsp-toolkit-webhelp-to-json/testResults/2651A/\nTest failed for subfolder: /home/runner/work/tsp-toolkit-webhelp-to-json/tsp-toolkit-webhelp-to-json/testResults/2657A/\nTest failed for subfolder: /home/runner/work/tsp-toolkit-webhelp-to-json/tsp-toolkit-webhelp-to-json/testResults/DMM7510/\nNo JSON file found in subfolder: /home/runner/work/tsp-toolkit-webhelp-to-json/tsp-toolkit-webhelp-to-json/testResults/tsp-lua-5.0/\n
Total Failed Tests: 011111111111111111
Total Passed Tests: 0

esarver
esarver approved these changes Dec 11, 2024
View reviewed changes
Copy link
Member

@esarver esarver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jharajeev55 jharajeev55 merged commit decd035 into main Dec 11, 2024
5 checks passed
@jharajeev55 jharajeev55 deleted the task/TSP-929-handle-blockType-param-for-setblock()-command branch December 11, 2024 14:48
@github-actions GitHub Actions
Copy link

JSON File Check Results

Test failed for subfolder: /home/runner/work/tsp-toolkit-webhelp-to-json/tsp-toolkit-webhelp-to-json/testResults/2450/\nTest failed for subfolder: /home/runner/work/tsp-toolkit-webhelp-to-json/tsp-toolkit-webhelp-to-json/testResults/2460/\nTest failed for subfolder: /home/runner/work/tsp-toolkit-webhelp-to-json/tsp-toolkit-webhelp-to-json/testResults/2461/\nTest failed for subfolder: /home/runner/work/tsp-toolkit-webhelp-to-json/tsp-toolkit-webhelp-to-json/testResults/2470/\nTest failed for subfolder: /home/runner/work/tsp-toolkit-webhelp-to-json/tsp-toolkit-webhelp-to-json/testResults/2601B-PULSE/\nTest failed for subfolder: /home/runner/work/tsp-toolkit-webhelp-to-json/tsp-toolkit-webhelp-to-json/testResults/2601B/\nTest failed for subfolder: /home/runner/work/tsp-toolkit-webhelp-to-json/tsp-toolkit-webhelp-to-json/testResults/2602B/\nTest failed for subfolder: /home/runner/work/tsp-toolkit-webhelp-to-json/tsp-toolkit-webhelp-to-json/testResults/2604B/\nTest failed for subfolder: /home/runner/work/tsp-toolkit-webhelp-to-json/tsp-toolkit-webhelp-to-json/testResults/2611B/\nTest failed for subfolder: /home/runner/work/tsp-toolkit-webhelp-to-json/tsp-toolkit-webhelp-to-json/testResults/2612B/\nTest failed for subfolder: /home/runner/work/tsp-toolkit-webhelp-to-json/tsp-toolkit-webhelp-to-json/testResults/2614B/\nTest failed for subfolder: /home/runner/work/tsp-toolkit-webhelp-to-json/tsp-toolkit-webhelp-to-json/testResults/2634B/\nTest failed for subfolder: /home/runner/work/tsp-toolkit-webhelp-to-json/tsp-toolkit-webhelp-to-json/testResults/2635B/\nTest failed for subfolder: /home/runner/work/tsp-toolkit-webhelp-to-json/tsp-toolkit-webhelp-to-json/testResults/2636B/\nTest failed for subfolder: /home/runner/work/tsp-toolkit-webhelp-to-json/tsp-toolkit-webhelp-to-json/testResults/2651A/\nTest failed for subfolder: /home/runner/work/tsp-toolkit-webhelp-to-json/tsp-toolkit-webhelp-to-json/testResults/2657A/\nTest failed for subfolder: /home/runner/work/tsp-toolkit-webhelp-to-json/tsp-toolkit-webhelp-to-json/testResults/DMM7510/\nNo JSON file found in subfolder: /home/runner/work/tsp-toolkit-webhelp-to-json/tsp-toolkit-webhelp-to-json/testResults/tsp-lua-5.0/\n
Total Failed Tests: 011111111111111111
Total Passed Tests: 0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@esarver esarver esarver approved these changes

Assignees

@jharajeev55 jharajeev55

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jharajeev55 @esarver