Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ReadSTB Timing #38

Merged
merged 4 commits into from
Oct 11, 2024
Merged

Fix ReadSTB Timing #38

merged 4 commits into from
Oct 11, 2024

Conversation

esarver
Copy link
Member

@esarver esarver commented Oct 10, 2024

This fixes the issue of calling ReadSTB() every 2ms when connected to an instrument over a VISA connection.

Now we only call ReadSTB() after the user sends something to the instrument (such as a TSP command, a script, or an upgrade) OR as a heartbeat every 3 seconds in the case an instrument stops responding.

Two scenarios:
1. After writing commands/scripts to the instrument
2. Every 3 seconds as a heartbeat
@esarver esarver self-assigned this Oct 10, 2024
@esarver esarver requested a review from a team as a code owner October 10, 2024 15:55
Copy link

github-actions bot commented Oct 10, 2024

Code Coverage

Package Line Rate Health
kic-discover-visa/src/ethernet/mod.rs 0%
kic-discover/src/lib.rs 0%
kic/src/main.rs 0%
kic-discover/src/instrument_discovery/mod.rs 0%
kic-discover-visa/src/main.rs 0%
kic-visa/src/process.rs 0%
instrument-repl/src/resources/mod.rs 100%
kic-discover-visa/src/instrument_discovery/mod.rs 0%
instrument-repl/src/instrument.rs 86%
kic-discover/src/ethernet/mod.rs 0%
instrument-repl/src/state_machine.rs 63%
kic-discover-visa/src/lib.rs 0%
kic/src/process.rs 0%
instrument-repl/src/tsp_error.rs 0%
kic-visa/src/main.rs 0%
kic-discover/src/main.rs 0%
kic-discover-visa/src/visa.rs 0%
instrument-repl/src/repl.rs 0%
kic-discover/src/process.rs 0%
Summary 11% (295 / 2579)

@esarver esarver merged commit 9beebde into main Oct 11, 2024
13 checks passed
@esarver esarver deleted the task/fix-readstb branch October 11, 2024 13:04
esarver added a commit to tektronix/tsp-toolkit that referenced this pull request Oct 11, 2024
esarver added a commit to tektronix/tsp-toolkit that referenced this pull request Oct 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants