Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add USBTMC support for the 3706A device. #97

Merged
merged 1 commit into from
Nov 9, 2023

Conversation

nfelt14
Copy link
Collaborator

@nfelt14 nfelt14 commented Nov 8, 2023

Proposed changes

Add USBTMC support for the 3706A device.

Types of changes

What types of changes does your code introduce?
Put an x in the boxes that apply

  • Functionality update (non-breaking change which updates or changes existing functionality)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have followed the guidelines in the CONTRIBUTING document
  • I have signed the CLA
  • I have checked to ensure there aren't other open Pull Requests for the same update/change
  • I have performed a self-review of my code
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • Basic linting passes locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have added necessary documentation (if appropriate)
  • I have updated the Changelog with a brief description of my changes

@nfelt14 nfelt14 requested a review from a team as a code owner November 8, 2023 23:14
@nfelt14 nfelt14 added the enhancement New feature or request label Nov 8, 2023
@tek-githubbot-1010 tek-githubbot-1010 requested a review from a team November 8, 2023 23:14
@nfelt14 nfelt14 enabled auto-merge (squash) November 8, 2023 23:14
Copy link

codecov bot commented Nov 8, 2023

Codecov Report

Merging #97 (403b41c) into main (78e0ed7) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##              main       #97   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          168       168           
  Lines         3768      3768           
  Branches       646       646           
=========================================
  Hits          3768      3768           
Files Coverage Δ
...rc/tm_devices/helpers/constants_and_dataclasses.py 100.00% <ø> (ø)

📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

@nfelt14 nfelt14 merged commit c0e133c into main Nov 9, 2023
36 checks passed
@nfelt14 nfelt14 deleted the nfelt14/3706a-usb-support branch November 9, 2023 00:31
qthompso pushed a commit to qthompso/tm_devices that referenced this pull request Feb 15, 2024
qthompso pushed a commit to qthompso/tm_devices that referenced this pull request Feb 16, 2024
v12ganesh pushed a commit to v12ganesh/tm_devices that referenced this pull request Mar 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants