Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Handle non-standard software versions with alpha characters in the last part of the version #81

Merged
merged 1 commit into from
Oct 30, 2023

Conversation

nfelt14
Copy link
Collaborator

@nfelt14 nfelt14 commented Oct 30, 2023

Proposed changes

Update a helper function to handle non-standard software version strings.

Types of changes

What types of changes does your code introduce?
Put an x in the boxes that apply

  • Bug fix (non-breaking change which fixes an issue)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have followed the guidelines in the CONTRIBUTING document
  • I have signed the CLA
  • I have checked to ensure there aren't other open Pull Requests for the same update/change
  • I have performed a self-review of my code
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • Basic linting passes locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have added necessary documentation (if appropriate)
  • I have updated the Changelog with a brief description of my changes

@nfelt14 nfelt14 requested a review from a team as a code owner October 30, 2023 17:08
@nfelt14 nfelt14 temporarily deployed to package-build October 30, 2023 17:09 — with GitHub Actions Inactive
@nfelt14 nfelt14 added the bug Something isn't working label Oct 30, 2023
@nfelt14 nfelt14 requested a review from a team October 30, 2023 17:09
@nfelt14 nfelt14 enabled auto-merge (squash) October 30, 2023 17:09
@codecov
Copy link

codecov bot commented Oct 30, 2023

Codecov Report

Merging #81 (9e922a8) into main (3dcab2c) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##              main       #81   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          168       168           
  Lines         3761      3768    +7     
  Branches       644       646    +2     
=========================================
+ Hits          3761      3768    +7     
Files Coverage Δ
src/tm_devices/helpers/functions.py 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@nfelt14 nfelt14 disabled auto-merge October 30, 2023 17:23
@nfelt14 nfelt14 force-pushed the nfelt14/handle-non-standard-software-versions branch from 330c1a2 to 9e922a8 Compare October 30, 2023 18:27
@nfelt14 nfelt14 temporarily deployed to package-build October 30, 2023 18:27 — with GitHub Actions Inactive
@nfelt14 nfelt14 enabled auto-merge (squash) October 30, 2023 18:27
@nfelt14 nfelt14 merged commit 608d728 into main Oct 30, 2023
34 checks passed
@nfelt14 nfelt14 deleted the nfelt14/handle-non-standard-software-versions branch October 30, 2023 19:21
qthompso pushed a commit to qthompso/tm_devices that referenced this pull request Feb 15, 2024
qthompso pushed a commit to qthompso/tm_devices that referenced this pull request Feb 16, 2024
v12ganesh pushed a commit to v12ganesh/tm_devices that referenced this pull request Mar 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants