-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Build docs without parallelization to fix pop-up issues with sphinx-tippy #80
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nfelt14
added
bug
Something isn't working
documentation
Improvements or additions to documentation
labels
Oct 30, 2023
Codecov Report
@@ Coverage Diff @@
## main #80 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 168 168
Lines 3768 3768
Branches 646 646
=========================================
Hits 3768 3768 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
A normal doc build used to take about 45 minutes, but the pop-ups were non-functional. Now the build takes 65 minutes, but the pop-ups are functional. |
This PR works around this issue: sphinx-extensions2/sphinx-tippy#9 |
nfelt14
commented
Oct 30, 2023
nfelt14
force-pushed
the
nfelt14/fix-tippy-pop-ups-in-docs
branch
from
October 30, 2023 21:23
a3924cd
to
1e57043
Compare
…t seems that tippy has a bug when run in parallelization in sphinx.
nfelt14
force-pushed
the
nfelt14/fix-tippy-pop-ups-in-docs
branch
from
October 30, 2023 21:24
1e57043
to
b5d4a50
Compare
It slowed the build down significantly, more than was acceptable.
michaelwagoner
previously approved these changes
Oct 30, 2023
michaelwagoner
approved these changes
Oct 30, 2023
qthompso
pushed a commit
to qthompso/tm_devices
that referenced
this pull request
Feb 15, 2024
…inx-tippy (tektronix#80) * fix: Run the docs environment in tox without parallelization, since it seems that tippy has a bug when run in parallelization in sphinx. * ci: Set up tags to be signed as well. Signed-off-by: qthompso <[email protected]>
qthompso
pushed a commit
to qthompso/tm_devices
that referenced
this pull request
Feb 16, 2024
…inx-tippy (tektronix#80) * fix: Run the docs environment in tox without parallelization, since it seems that tippy has a bug when run in parallelization in sphinx. * ci: Set up tags to be signed as well.
v12ganesh
pushed a commit
to v12ganesh/tm_devices
that referenced
this pull request
Mar 28, 2024
…inx-tippy (tektronix#80) * fix: Run the docs environment in tox without parallelization, since it seems that tippy has a bug when run in parallelization in sphinx. * ci: Set up tags to be signed as well. Signed-off-by: v12ganesh [email protected]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Run doc building without parallelization to try to work around a bug in sphinx-tippy.
Types of changes
What types of changes does your code introduce?
Put an
x
in the boxes that apply and remove the ones that don'tChecklist
Put an
x
in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.