Update the code that checks for package updates #66
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: Replaced a third-party package used to check for updates with a few lines of code to perform a request and parse the returned json. This prevents a PermissionsError from happening on some systems. Also added a flag to enable the check for updates, it now defaults to off.
Proposed changes
This fixes a potential
PermissionsError
by replacing a third-party package with a direct usage ofrequests.get()
. A config option was added, defaulting toFalse
, that can enable a check for updates when theDeviceManager
is first instantiated if the user wants to have that behavior.Types of changes
What types of changes does your code introduce?
Put an
x
in the boxes that applyChecklist
Put an
x
in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.