Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Update workflow to enable signed commits. #37

Merged
merged 3 commits into from
Oct 20, 2023

Conversation

nfelt14
Copy link
Collaborator

@nfelt14 nfelt14 commented Oct 19, 2023

Proposed changes

Updates the release workflow to properly sign the new commits and use secrets/vars to access the necessary account info to make future changes easier. Also updated the changelog template to not include PRs if there are none, though that should never happen.

Types of changes

What types of changes does your code introduce?
Put an x in the boxes that apply

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Functionality update (non-breaking change which updates or changes existing functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • CI/CD update (an update to the CI/CD workflows, scripts, and/or configurations)
  • Documentation update (an update to enhance the user experience when reading through the docs)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have followed the guidelines in the CONTRIBUTING document
  • I have signed the CLA
  • I have checked to ensure there aren't other open Pull Requests for the same update/change
  • I have performed a self-review of my code
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • Basic linting passes locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have added necessary documentation (if appropriate)
  • I have updated the Changelog with a brief description of my changes

@nfelt14 nfelt14 requested a review from a team as a code owner October 19, 2023 23:04
@nfelt14 nfelt14 temporarily deployed to package-build October 19, 2023 23:04 — with GitHub Actions Inactive
@nfelt14 nfelt14 added bug Something isn't working enhancement New feature or request ci/cd Improvements or additions to the CI/CD process labels Oct 19, 2023
@nfelt14 nfelt14 requested a review from a team October 19, 2023 23:04
@nfelt14 nfelt14 enabled auto-merge (squash) October 19, 2023 23:05
@codecov
Copy link

codecov bot commented Oct 19, 2023

Codecov Report

Merging #37 (bec2b86) into main (18f1a2c) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##              main       #37   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          168       168           
  Lines         3757      3757           
  Branches       646       646           
=========================================
  Hits          3757      3757           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@nfelt14 nfelt14 temporarily deployed to package-build October 20, 2023 00:27 — with GitHub Actions Inactive
…ction. Also update workflow name for TestPyPI upload to make badge smaller.
@nfelt14 nfelt14 temporarily deployed to package-build October 20, 2023 00:35 — with GitHub Actions Inactive
.github/workflows/package-release.yml Outdated Show resolved Hide resolved
@nfelt14 nfelt14 merged commit 0bf4356 into main Oct 20, 2023
34 checks passed
@nfelt14 nfelt14 deleted the nfelt14/sign-release-commit branch October 20, 2023 16:45
v12ganesh pushed a commit to v12ganesh/tm_devices that referenced this pull request Mar 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working ci/cd Improvements or additions to the CI/CD process enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants