-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use logging module instead of prints #345
Merged
nfelt14
merged 12 commits into
tektronix:main
from
nfelt14:use-logging-instead-of-prints
Nov 15, 2024
Merged
Use logging module instead of prints #345
nfelt14
merged 12 commits into
tektronix:main
from
nfelt14:use-logging-instead-of-prints
Nov 15, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…formation to stdout. This provides users with more control over stdout and also allows for logging outputs to files.
Also updated the tests to work properly with the new logging
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #345 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 160 161 +1
Lines 4547 4645 +98
Branches 799 777 -22
=========================================
+ Hits 4547 4645 +98 ☔ View full report in Codecov by Sentry. |
Things still needing to be added:
|
… instead of builtins where possible.
nfelt14
temporarily deployed
to
package-build
November 11, 2024 17:58 — with
GitHub Actions
Inactive
…configure logging.
nfelt14
temporarily deployed
to
package-build
November 12, 2024 00:31 — with
GitHub Actions
Inactive
nfelt14
temporarily deployed
to
package-build
November 12, 2024 04:22 — with
GitHub Actions
Inactive
nfelt14
commented
Nov 12, 2024
nfelt14
temporarily deployed
to
package-build
November 12, 2024 18:55 — with
GitHub Actions
Inactive
nfelt14
temporarily deployed
to
package-build
November 12, 2024 19:36 — with
GitHub Actions
Inactive
michaelwagoner
previously approved these changes
Nov 12, 2024
ldantek
reviewed
Nov 13, 2024
ldantek
previously approved these changes
Nov 13, 2024
…i-line VISA write. Also updated unit test simulated devices and locked the version of pyright.
nfelt14
temporarily deployed
to
package-build
November 15, 2024 16:28 — with
GitHub Actions
Inactive
Breaking API Changes
|
Test Results (windows)
|
Test Results (macos)
|
Test Results (ubuntu)
|
ldantek
approved these changes
Nov 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
This switches tm_devices to use logging instead of normal printing. A new function,
configure_logging()
is provided so that users can configure what is being logged where. The default behavior keeps the stdout output very similar and adds a file log that contains all logging output.The log file also can be configured to including the debug output from pyvisa, since that library is crucial to debugging issues connecting to devices.
Addresses #319 and #316
Types of changes
What types of changes does your code introduce?
Put an
x
in the boxes that applyChecklist
Put an
x
in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.Addresses #<issue_number>