-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add screen capture functionality for TekScope device driver family #342
Conversation
…for the TekScope family of device drivers
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #342 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 159 160 +1
Lines 4489 4547 +58
Branches 784 799 +15
=========================================
+ Hits 4489 4547 +58 ☔ View full report in Codecov by Sentry. |
…y and on TekScope. Also added an example to the basic_usage.md file.
src/tm_devices/driver_mixins/abstract_device_functionality/screen_capture_mixin.py
Outdated
Show resolved
Hide resolved
Couple questions: |
My thoughts would be to let the user decide if they want the filename to be datetime or not, then tm_devices doesn't need to worry about name collisions, since that is out of its control. |
For that first part I meant more along the lines of allowing |
I could add that in. |
…t will now default to a timestamped filename
Test Results (ubuntu)
|
Test Results (windows)
|
Test Results (macos)
|
Proposed changes
feat: Added a screen capture mixin and implemented the functionality for the TekScope family of device drivers
Types of changes
What types of changes does your code introduce?
Put an
x
in the boxes that applyChecklist
Put an
x
in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.Addresses #<issue_number>