-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TekScope2K - turn on HEADER and VERBOSE options to query available data sources correctly #327
Conversation
Blocked by PyCQA/docformatter#293 |
@RoaCode you will need to rebase your branch to get builds to pass |
@RoaCode, it looks like there are more conflicts with the changelog |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #327 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 152 152
Lines 4904 4907 +3
Branches 780 780
=========================================
+ Hits 4904 4907 +3 ☔ View full report in Codecov by Sentry. |
@RoaCode your last few commits are unsigned |
@RoaCode, it looks like this needs to be rebased again |
…ions properly Added HEADER calls to 'get_available_data_sources' function
Added driver functions for MSO2KB series oscilloscope. Added "curve_query", "all_channel_names_list", "turn_channel_on/off", and "total_channels" functions, and added model ID 0x03A4 to supported models list
…CT? functions properly If the MSO2K scope is not in HEADER and VERBOSE mode when SELECT? is called to determine the number of active channels, the channel names will not be read properly
… returns to original state
Co-authored-by: Nicholas Felt <[email protected]> Signed-off-by: Joe <[email protected]>
Co-authored-by: Nicholas Felt <[email protected]> Signed-off-by: Joe <[email protected]>
Test Results (ubuntu)
|
Test Results (windows)
|
Test Results (macos)
|
Proposed changes
Please include a summary of the changes and any links to related issues. Please also include relevant motivation and context.
Addresses #326
Types of changes
What types of changes does your code introduce?
Put an
x
in the boxes that applyChecklist
Put an
x
in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.Addresses #<issue_number>