Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added SourceXpress APIs support and AWG defects fix. #255

Closed
wants to merge 18 commits into from

Conversation

v12ganesh
Copy link
Contributor

Proposed changes

Please include a summary of the changes and any links to related issues. Please also include relevant motivation and context.

Types of changes

What types of changes does your code introduce?
Put an x in the boxes that apply

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Functionality update (non-breaking change which updates or changes existing functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • CI/CD update (an update to the CI/CD workflows, scripts, and/or configurations)
  • Documentation update (an update to enhance the user experience when reading through the docs)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have followed the guidelines in the CONTRIBUTING document
  • I have signed the CLA
  • I have checked to ensure there aren't other open Pull Requests for the same update/change
  • I have performed a self-review of my code
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • Basic linting passes locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have added necessary documentation (if appropriate)
  • I have updated the Changelog with a brief description of my changes

@v12ganesh v12ganesh requested review from a team as code owners July 26, 2024 12:52
CHANGELOG.md Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
u625355
u625355 previously approved these changes Jul 29, 2024
Copy link

codecov bot commented Jul 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (12f4a71) to head (527b956).

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #255   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          152       152           
  Lines         4829      4829           
  Branches       768       768           
=========================================
  Hits          4829      4829           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@nfelt14 nfelt14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You will also need to rebase your branch with the latest from main

CHANGELOG.md Outdated Show resolved Hide resolved
docs/glossary.md Outdated Show resolved Hide resolved
docs/glossary.md Show resolved Hide resolved
@v12ganesh v12ganesh force-pushed the ganesh12/api-defect-fix branch from c4d6c41 to 6c9527e Compare July 29, 2024 18:10
v12ganesh and others added 6 commits July 29, 2024 23:44
…tes (tektronix#257)

* python-deps(deps-dev): bump the python-dependencies group with 2 updates

Updates the requirements on [pyright](https://github.com/RobertCraigie/pyright-python) and [ruff](https://github.com/astral-sh/ruff) to permit the latest version.

Updates `pyright` to 1.1.373
- [Release notes](https://github.com/RobertCraigie/pyright-python/releases)
- [Commits](RobertCraigie/pyright-python@v1.1.372...v1.1.373)

Updates `ruff` to 0.5.5
- [Release notes](https://github.com/astral-sh/ruff/releases)
- [Changelog](https://github.com/astral-sh/ruff/blob/main/CHANGELOG.md)
- [Commits](astral-sh/ruff@0.5.4...0.5.5)

---
updated-dependencies:
- dependency-name: pyright
  dependency-type: direct:development
  dependency-group: python-dependencies
- dependency-name: ruff
  dependency-type: direct:development
  dependency-group: python-dependencies
...

Signed-off-by: dependabot[bot] <[email protected]>

* ci: Update python linters and pre-commit dependencies.

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Tektronix Bot <[email protected]>
…nix#258)

Bumps the gh-actions-dependencies group with 1 update in the / directory: [hynek/build-and-inspect-python-package](https://github.com/hynek/build-and-inspect-python-package).


Updates `hynek/build-and-inspect-python-package` from 2.7.0 to 2.8.0
- [Release notes](https://github.com/hynek/build-and-inspect-python-package/releases)
- [Changelog](https://github.com/hynek/build-and-inspect-python-package/blob/main/CHANGELOG.md)
- [Commits](hynek/build-and-inspect-python-package@v2.7.0...v2.8.0)

---
updated-dependencies:
- dependency-name: hynek/build-and-inspect-python-package
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: gh-actions-dependencies
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@nfelt14 nfelt14 enabled auto-merge (squash) July 29, 2024 18:21
Copy link

github-actions bot commented Jul 29, 2024

Breaking API Changes

src/tm_devices/commands/gen_fuzvln_lpdmsodpodsa/header.py:0: <module>:
Public object was removed

src/tm_devices/commands/gen_fuzvln_lpdmsodpodsa/verbose.py:0: <module>:
Public object was removed

src/tm_devices/commands/gen_3n9auv_awg/diagnostic.py:0: <module>:
Public object was removed

src/tm_devices/commands/gen_1nmc1o_msodpomdo/header.py:0: <module>:
Public object was removed

src/tm_devices/commands/gen_1nmc1o_msodpomdo/verbose.py:0: <module>:
Public object was removed

Link to workflow run

Copy link

github-actions bot commented Jul 29, 2024

Test Results (ubuntu)

path passed subtotal
tests/test_afgs.py 2 2
tests/test_alias_dict.py 1 1
tests/test_all_device_drivers.py 1 1
tests/test_alternative_connection_addresses.py 19 19
tests/test_awgs.py 4 4
tests/test_config_parser.py 38 38
tests/test_device_manager.py 18 18
tests/test_devices_legacy_tsp_ieee_cmds.py 3 3
tests/test_generate_waveform.py 6 6
tests/test_helpers.py 71 71
tests/test_ieee_scpi_cmds.py 1 1
tests/test_margin_testers.py 5 5
tests/test_pi_device.py 1 1
tests/test_psu.py 1 1
tests/test_rest_api_device.py 10 10
tests/test_scopes.py 7 7
tests/test_singleton.py 1 1
tests/test_smu.py 4 4
tests/test_ss.py 1 1
tests/test_tm_devices.py 4 4
TOTAL 198 198

Link to workflow run

Copy link

github-actions bot commented Jul 29, 2024

Test Results (macos)

path passed subtotal
tests/test_afgs.py 2 2
tests/test_alias_dict.py 1 1
tests/test_all_device_drivers.py 1 1
tests/test_alternative_connection_addresses.py 19 19
tests/test_awgs.py 4 4
tests/test_config_parser.py 38 38
tests/test_device_manager.py 18 18
tests/test_devices_legacy_tsp_ieee_cmds.py 3 3
tests/test_generate_waveform.py 6 6
tests/test_helpers.py 71 71
tests/test_ieee_scpi_cmds.py 1 1
tests/test_margin_testers.py 5 5
tests/test_pi_device.py 1 1
tests/test_psu.py 1 1
tests/test_rest_api_device.py 10 10
tests/test_scopes.py 7 7
tests/test_singleton.py 1 1
tests/test_smu.py 4 4
tests/test_ss.py 1 1
tests/test_tm_devices.py 4 4
TOTAL 198 198

Link to workflow run

Copy link

github-actions bot commented Jul 29, 2024

Test Results (windows)

path passed subtotal
tests\test_afgs.py 2 2
tests\test_alias_dict.py 1 1
tests\test_all_device_drivers.py 1 1
tests\test_alternative_connection_addresses.py 19 19
tests\test_awgs.py 4 4
tests\test_config_parser.py 38 38
tests\test_device_manager.py 18 18
tests\test_devices_legacy_tsp_ieee_cmds.py 3 3
tests\test_generate_waveform.py 6 6
tests\test_helpers.py 71 71
tests\test_ieee_scpi_cmds.py 1 1
tests\test_margin_testers.py 5 5
tests\test_pi_device.py 1 1
tests\test_psu.py 1 1
tests\test_rest_api_device.py 10 10
tests\test_scopes.py 7 7
tests\test_singleton.py 1 1
tests\test_smu.py 4 4
tests\test_ss.py 1 1
tests\test_tm_devices.py 4 4
TOTAL 198 198

Link to workflow run

Copy link
Collaborator

@nfelt14 nfelt14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please sign all of your commits

@u625355
Copy link
Contributor

u625355 commented Jul 30, 2024

Please sign all of your commits

@v12ganesh ,Until you sign all of your commits, PR cannot be merged.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ v12ganesh
❌ dependabot[bot]
You have signed the CLA already but the status is still pending? Let us recheck it.

@v12ganesh
Copy link
Contributor Author

Due to merge conflicts and SSH key issue, closing this PR.

@v12ganesh v12ganesh closed this Jul 30, 2024
auto-merge was automatically disabled July 30, 2024 16:21

Pull request was closed

@v12ganesh v12ganesh deleted the ganesh12/api-defect-fix branch July 30, 2024 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants