-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Signal Generation Restructure and addition of high level methods #246
Merged
nfelt14
merged 10 commits into
tektronix:main
from
qthompso:function_generation_refactor
Jul 24, 2024
Merged
Signal Generation Restructure and addition of high level methods #246
nfelt14
merged 10 commits into
tektronix:main
from
qthompso:function_generation_refactor
Jul 24, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #246 +/- ##
==========================================
Coverage 100.00% 100.00%
==========================================
Files 150 152 +2
Lines 4139 4829 +690
Branches 651 768 +117
==========================================
+ Hits 4139 4829 +690 ☔ View full report in Codecov by Sentry. |
nfelt14
changed the title
Added function generation
Signal Generation Restructure and addition of high level methods
Jul 9, 2024
17 tasks
nfelt14
requested changes
Jul 9, 2024
nfelt14
requested changes
Jul 12, 2024
nfelt14
requested changes
Jul 12, 2024
nfelt14
force-pushed
the
function_generation_refactor
branch
from
July 15, 2024 16:37
dfa2860
to
c574d23
Compare
nfelt14
previously requested changes
Jul 15, 2024
nfelt14
previously approved these changes
Jul 16, 2024
nfelt14
previously approved these changes
Jul 23, 2024
ldantek
reviewed
Jul 23, 2024
ldantek
previously approved these changes
Jul 23, 2024
Signed-off-by: qthompso <[email protected]>
michaelwagoner
previously approved these changes
Jul 23, 2024
Signed-off-by: qthompso <[email protected]>
qthompso
dismissed stale reviews from michaelwagoner, ldantek, and nfelt14
via
July 23, 2024 23:07
34229f7
nfelt14
requested changes
Jul 24, 2024
Signed-off-by: qthompso <[email protected]>
Signed-off-by: qthompso <[email protected]>
Breaking API Changes
|
nfelt14
approved these changes
Jul 24, 2024
Test Results (ubuntu)
|
Test Results (windows)
|
Test Results (macos)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
This PR contains a fundamental change to how the signal generator (previously signal source) class is structured.
Along with this, there is a the introduction of many more high level functions to help with generating functions.
Please view the signal_generators.md documentation file for an in depth view of each of these methods.
Added
source_channel
in AWG's and AFG's.internal_afg
in TekScope.generate_function
for all AWG models.OutputSignalPath
enum attribute in AWG's representing output signal path options.sample_waveform_set_file
attribute in AWG70k's and AWG5200 to define the default waveform set file.Changed
generate_waveform()
togenerate_function()
.generate_waveform()
only exists on AWGs now, however the functionality is entirely changed.generate_function()
function by removing burst functionality.setup_burst()
andgenerate_burst()
instead.family_base_class
is at the model level.Types of changes
What types of changes does your code introduce?
Put an
x
in the boxes that applyChecklist
Put an
x
in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.