Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix TestPyPI upload #22

Merged
merged 8 commits into from
Oct 5, 2023
Merged

Fix TestPyPI upload #22

merged 8 commits into from
Oct 5, 2023

Conversation

nfelt14
Copy link
Collaborator

@nfelt14 nfelt14 commented Oct 5, 2023

Proposed changes

Fixes the TestPyPI upload workflow.

Types of changes

What types of changes does your code introduce?
Put an x in the boxes that apply

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Functionality update (non-breaking change which updates or changes existing functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • CI/CD update (an update to the CI/CD workflows, scripts, and/or configurations)
  • Documentation update (an update to enhance the user experience when reading through the docs)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have followed the guidelines in the CONTRIBUTING document
  • I have signed the CLA
  • I have checked to ensure there aren't other open Pull Requests for the same update/change
  • I have performed a self-review of my code
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • Basic linting passes locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have added necessary documentation (if appropriate)
  • I have updated the Changelog with a brief description of my changes

@nfelt14 nfelt14 temporarily deployed to package-build October 5, 2023 20:24 — with GitHub Actions Inactive
@codecov
Copy link

codecov bot commented Oct 5, 2023

Codecov Report

Merging #22 (2064a11) into main (a30cb3d) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##              main       #22   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          168       168           
  Lines         3756      3756           
  Branches       646       646           
=========================================
  Hits          3756      3756           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@nfelt14 nfelt14 temporarily deployed to package-build October 5, 2023 20:27 — with GitHub Actions Inactive
@nfelt14 nfelt14 temporarily deployed to package-build October 5, 2023 20:36 — with GitHub Actions Inactive
@nfelt14 nfelt14 temporarily deployed to package-build October 5, 2023 20:38 — with GitHub Actions Inactive
@nfelt14 nfelt14 temporarily deployed to package-build October 5, 2023 20:41 — with GitHub Actions Inactive
@nfelt14 nfelt14 temporarily deployed to package-build October 5, 2023 20:44 — with GitHub Actions Inactive
@nfelt14 nfelt14 temporarily deployed to package-build October 5, 2023 20:46 — with GitHub Actions Inactive
@nfelt14
Copy link
Collaborator Author

nfelt14 commented Oct 5, 2023

The failed deployment to the testpypi environment can be ignored, it was just testing the workflow with a few things removed. I have added back the components that were commented out and once the PR merges the workflow will pass.

@nfelt14 nfelt14 marked this pull request as ready for review October 5, 2023 20:48
@nfelt14 nfelt14 requested a review from a team as a code owner October 5, 2023 20:48
@nfelt14 nfelt14 requested a review from a team October 5, 2023 20:48
@nfelt14 nfelt14 enabled auto-merge (squash) October 5, 2023 20:48
@nfelt14 nfelt14 merged commit a322178 into main Oct 5, 2023
35 checks passed
@nfelt14 nfelt14 deleted the nfelt14/bugfix/testpypi-upload branch October 5, 2023 21:33
v12ganesh pushed a commit to v12ganesh/tm_devices that referenced this pull request Mar 28, 2024
* ci: Include package output dir in workflow step.

* ci: Add a step to copy the package files to the proper directory.

* ci: Create the dist directory before trying to copy files into it.
Signed-off-by: v12ganesh [email protected]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants