Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upload unique dev packages to test.pypi.org #19

Merged
merged 15 commits into from
Oct 5, 2023

Conversation

nfelt14
Copy link
Collaborator

@nfelt14 nfelt14 commented Oct 4, 2023

Proposed changes

Updated the test.pypi.org uploaded version to have a unique version metadata string to prevent duplicate uploads.

This is a temporary hotfix and the entire package build/upload workflow will be updated in the future.

Types of changes

What types of changes does your code introduce?
Put an x in the boxes that apply

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Functionality update (non-breaking change which updates or changes existing functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have followed the guidelines in the CONTRIBUTING document
  • I have signed the CLA
  • I have checked to ensure there aren't other open Pull Requests for the same update/change
  • I have performed a self-review of my code
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • Basic linting passes locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have added necessary documentation (if appropriate)
  • I have updated the Changelog with a brief description of my changes

…ion already exists. This is a temporary hotfix and the entire package build/upload workflow will be updated in the future.
@nfelt14 nfelt14 requested a review from a team as a code owner October 4, 2023 20:40
@nfelt14 nfelt14 requested a review from a team October 4, 2023 20:40
@codecov
Copy link

codecov bot commented Oct 4, 2023

Codecov Report

Merging #19 (e5294e6) into main (e65c5ba) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##              main       #19   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          168       168           
  Lines         3756      3756           
  Branches       646       646           
=========================================
  Hits          3756      3756           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

michaelwagoner
michaelwagoner previously approved these changes Oct 4, 2023
@nfelt14 nfelt14 requested review from michaelwagoner, ldantek and a team October 4, 2023 21:35
@nfelt14 nfelt14 changed the title Skip existing package version upload to test.pypi.org Upload unique dev packages to test.pypi.org Oct 4, 2023
@nfelt14 nfelt14 enabled auto-merge (squash) October 4, 2023 21:39
@nfelt14 nfelt14 disabled auto-merge October 4, 2023 22:41
@nfelt14 nfelt14 enabled auto-merge (squash) October 4, 2023 22:41
@nfelt14 nfelt14 disabled auto-merge October 5, 2023 16:42
@nfelt14 nfelt14 enabled auto-merge (squash) October 5, 2023 16:43
@nfelt14 nfelt14 merged commit 2829a09 into main Oct 5, 2023
36 checks passed
@nfelt14 nfelt14 deleted the nfelt14/hotfix/test-pypi-upload branch October 5, 2023 17:23
v12ganesh pushed a commit to v12ganesh/tm_devices that referenced this pull request Mar 28, 2024
* ci: Update workflow that uploads to test.pypi.org to create a unique version to upload first.

* ci: Switch to using the official GitHub action.

* ci: Add write permission for contents.

* build: Fix the semantic release config to properly set the new version.

* docs: Update badge for documentation build status to point to the latest docs.

* docs: Fix broken link to doc badge.

* docs: Fix doc badge image

* ci: Updated the pull request template with an entry for CI/CD updates.
Signed-off-by: v12ganesh [email protected]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants