Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Python 3.12 support #16

Merged
merged 10 commits into from
Oct 3, 2023
Merged

Add Python 3.12 support #16

merged 10 commits into from
Oct 3, 2023

Conversation

nfelt14
Copy link
Collaborator

@nfelt14 nfelt14 commented Oct 3, 2023

Resolves #17

@nfelt14 nfelt14 requested a review from a team as a code owner October 3, 2023 03:21
@nfelt14 nfelt14 requested a review from a team October 3, 2023 03:21
@codecov
Copy link

codecov bot commented Oct 3, 2023

Codecov Report

Merging #16 (a226346) into main (4eb4f1f) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##              main       #16   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          168       168           
  Lines         3756      3756           
  Branches       676       646   -30     
=========================================
  Hits          3756      3756           
Files Coverage Δ
...c/tm_devices/drivers/pi/signal_sources/afgs/afg.py 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@nfelt14
Copy link
Collaborator Author

nfelt14 commented Oct 3, 2023

  • Wait for Python 3.12 to become available in the setup-python action

@nfelt14
Copy link
Collaborator Author

nfelt14 commented Oct 3, 2023

  • Need to update the package version and changelog

michaelwagoner
michaelwagoner previously approved these changes Oct 3, 2023
@nfelt14 nfelt14 requested review from a team, michaelwagoner and ldantek October 3, 2023 18:19
@nfelt14 nfelt14 added the enhancement New feature or request label Oct 3, 2023
@nfelt14 nfelt14 merged commit 227972f into main Oct 3, 2023
36 checks passed
@nfelt14 nfelt14 deleted the nfelt14/add-python312-support branch October 3, 2023 19:06
v12ganesh pushed a commit to v12ganesh/tm_devices that referenced this pull request Mar 28, 2024
* refactor: Updated linting directives and settings to enable Python 3.12 linting to function correctly.

* style: Update ruff pre-commit version.

* ci: Add testing for Python 3.12.

* docs: Bumped the version to indicate support for Python 3.12.

* ci: Add package to pre-commit hook to account for changes in Python 3.12.

* ci: Enable pyright debugging to troubleshoot python 3.12 issues.

* ci: Add Codecov token to workflow.

* build: Add setuptools as a required package for python 3.12 development.

* ci: disable using global node for pyright

* ci: Update environment variables in tox and add a comment about what it is doing.
Signed-off-by: v12ganesh [email protected]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEAT]: Python 3.12 Support
2 participants