Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: modified API under MSO 2,4,5,6 modules #142

Merged
merged 3 commits into from
Feb 8, 2024

Conversation

u625355
Copy link
Contributor

@u625355 u625355 commented Feb 8, 2024

Modified APIs under MSO 2, 4|5|6 modules.
Added default buffer to SMU 26xx series.

Proposed changes

Please include a summary of the changes and any links to related issues. Please also include relevant motivation and context.

Types of changes

What types of changes does your code introduce?
Put an x in the boxes that apply

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Functionality update (non-breaking change which updates or changes existing functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • CI/CD update (an update to the CI/CD workflows, scripts, and/or configurations)
  • Documentation update (an update to enhance the user experience when reading through the docs)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have followed the guidelines in the CONTRIBUTING document
  • I have signed the CLA
  • I have checked to ensure there aren't other open Pull Requests for the same update/change
  • I have performed a self-review of my code
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • Basic linting passes locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have added necessary documentation (if appropriate)
  • I have updated the Changelog with a brief description of my changes

@u625355 u625355 requested review from a team as code owners February 8, 2024 20:06
Copy link

codecov bot commented Feb 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (2400d8e) 100.00% compared to head (5c809f3) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #142   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          170       170           
  Lines         3801      3801           
  Branches       657       657           
=========================================
  Hits          3801      3801           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nfelt14 nfelt14 merged commit f84c3ea into tektronix:main Feb 8, 2024
36 checks passed
@nfelt14 nfelt14 deleted the shashank55/defect-fix branch February 8, 2024 23:03
v12ganesh pushed a commit to v12ganesh/tm_devices that referenced this pull request Mar 28, 2024
* fix: modified API under MSO 2,4,5,6 modules and added default buffer to SMU 26xx series.

* fix: updated the CHANGELOG.md

* fix: removed extra newline in CHANGELOG.md

Signed-off-by: Shashank P <[email protected]>

---------

Signed-off-by: Shashank P <[email protected]>
Signed-off-by: v12ganesh [email protected]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants