-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
style: Update linting rules. #132
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* ci: Add explicit disable of a new pyright rule. * style: Updated all type ignore comments to include specific error codes. * style: Updated code to pass more ruff style checks for pathlib usage. * style: Updated code to always use timezones when working with datetime objects.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #132 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 170 170
Lines 3791 3793 +2
Branches 655 655
=========================================
+ Hits 3791 3793 +2 ☔ View full report in Codecov by Sentry. |
michaelwagoner
previously approved these changes
Jan 24, 2024
…avoid issues in Python 3.8.
michaelwagoner
approved these changes
Jan 24, 2024
qthompso
pushed a commit
to qthompso/tm_devices
that referenced
this pull request
Feb 15, 2024
* ci: Add explicit disable of a new pyright rule. * style: Updated all type ignore comments to include specific error codes. * style: Updated code to pass more ruff style checks for pathlib usage. * style: Updated code to always use timezones when working with datetime objects. Signed-off-by: qthompso <[email protected]>
qthompso
pushed a commit
to qthompso/tm_devices
that referenced
this pull request
Feb 16, 2024
* ci: Add explicit disable of a new pyright rule. * style: Updated all type ignore comments to include specific error codes. * style: Updated code to pass more ruff style checks for pathlib usage. * style: Updated code to always use timezones when working with datetime objects.
v12ganesh
pushed a commit
to v12ganesh/tm_devices
that referenced
this pull request
Mar 28, 2024
* ci: Add explicit disable of a new pyright rule. * style: Updated all type ignore comments to include specific error codes. * style: Updated code to pass more ruff style checks for pathlib usage. * style: Updated code to always use timezones when working with datetime objects. Signed-off-by: v12ganesh [email protected]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Types of changes
What types of changes does your code introduce?
Put an
x
in the boxes that applyChecklist
Put an
x
in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.