Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Added a mechanism to reset cached properties whenever a device is rebooted. #118

Merged
merged 1 commit into from
Dec 12, 2023

Conversation

nfelt14
Copy link
Collaborator

@nfelt14 nfelt14 commented Dec 12, 2023

Proposed changes

When a device is rebooted some properties may change. In order to prevent this from causing issues, a mechanism was added to the reboot() method that will reset all cached properties when .reboot() is called.

Types of changes

What types of changes does your code introduce?
Put an x in the boxes that apply

  • Functionality update (non-breaking change which updates or changes existing functionality)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have followed the guidelines in the CONTRIBUTING document
  • I have signed the CLA
  • I have checked to ensure there aren't other open Pull Requests for the same update/change
  • I have performed a self-review of my code
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • Basic linting passes locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have added necessary documentation (if appropriate)
  • I have updated the Changelog with a brief description of my changes

@nfelt14 nfelt14 requested review from a team as code owners December 12, 2023 00:45
Copy link

codecov bot commented Dec 12, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (913a172) 100.00% compared to head (a2a0ee2) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #118   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          169       169           
  Lines         3782      3789    +7     
  Branches       649       654    +5     
=========================================
+ Hits          3782      3789    +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nfelt14 nfelt14 merged commit b67080c into main Dec 12, 2023
37 checks passed
@nfelt14 nfelt14 deleted the nfelt14/reset-cached-properties-on-device-reboot branch December 12, 2023 01:55
qthompso pushed a commit to qthompso/tm_devices that referenced this pull request Feb 15, 2024
qthompso pushed a commit to qthompso/tm_devices that referenced this pull request Feb 16, 2024
v12ganesh pushed a commit to v12ganesh/tm_devices that referenced this pull request Mar 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants