Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update package-release workflow to prevent marking the workflow as failed if the deployment is rejected #84

Merged
merged 11 commits into from
Sep 9, 2024

Conversation

nfelt14
Copy link
Collaborator

@nfelt14 nfelt14 commented Sep 9, 2024

Proposed changes

Previously, the repo's package-release workflow badge would go red (for a failure) if a deployment was rejected. Now the remainder of the jobs in the workflow will simply skip so that no changes are applied to the repo. This allows the workflow run history to be preserved while still allowing the badge to stay green.

Types of changes

What types of changes does your code introduce?
Put an x in the boxes that apply

  • New feature (non-breaking change which adds functionality)
  • Functionality update (non-breaking change which updates or changes existing functionality)
  • CI/CD update (an update to the CI/CD workflows, scripts, and/or configurations)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have followed the guidelines in the CONTRIBUTING document
  • I have signed the CLA
  • I have checked to ensure there aren't other open Pull Requests for the same update/change
  • I have created (or updated) an Issue to track the status of this update/change and updated the link in this PR description (see above in the Proposed changes section) using the wording Addresses #<issue_number>
  • I have performed a self-review of my code
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • Basic linting passes locally with my changes
  • I have added necessary documentation (if appropriate)
  • I have updated the Changelog with a brief description of my changes

@nfelt14 nfelt14 requested a review from a team as a code owner September 9, 2024 15:37
@CLAassistant
Copy link

CLAassistant commented Sep 9, 2024

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ nfelt14
❌ renovate[bot]
You have signed the CLA already but the status is still pending? Let us recheck it.

@nfelt14 nfelt14 added the enhancement New feature or request label Sep 9, 2024
Copy link

codecov bot commented Sep 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (70b9e53) to head (56dc1f5).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main       #84   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            4         4           
  Lines          208       208           
  Branches        39        39           
=========================================
  Hits           208       208           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

fix: Update method of checking for approved runs to also account for the PSR step failing

test: Allow testing

� This is the commit message #3:

test: Allow testing

� This is the commit message #4:

0.0.1

Automatically generated by python-semantic-release

� This is the commit message #5:

Revert "test: Allow testing"

This reverts commit 9c9a5cd.
Copy link

github-actions bot commented Sep 9, 2024

Test Results (windows)

path passed subtotal
tests\test_bump_version_in_files.py 5 5
tests\test_create_unique_testpypi_version.py 7 7
tests\test_find_unreleased_changelog_items.py 5 5
tests\test_update_development_dependencies.py 13 13
TOTAL 30 30

Link to workflow run

Copy link

github-actions bot commented Sep 9, 2024

Test Results (ubuntu)

path passed subtotal
tests/test_bump_version_in_files.py 5 5
tests/test_create_unique_testpypi_version.py 7 7
tests/test_find_unreleased_changelog_items.py 5 5
tests/test_update_development_dependencies.py 13 13
TOTAL 30 30

Link to workflow run

Copy link

github-actions bot commented Sep 9, 2024

Test Results (macos)

path passed subtotal
tests/test_bump_version_in_files.py 5 5
tests/test_create_unique_testpypi_version.py 7 7
tests/test_find_unreleased_changelog_items.py 5 5
tests/test_update_development_dependencies.py 13 13
TOTAL 30 30

Link to workflow run

@nfelt14 nfelt14 merged commit 55821c1 into tektronix:main Sep 9, 2024
39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants