-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update package-release workflow to prevent marking the workflow as failed if the deployment is rejected #84
Conversation
--------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Felt, Nicholas <[email protected]>
… if the review is rejected
This reverts commit e5ec7c7.
This reverts commit 72b1b57.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #84 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 4 4
Lines 208 208
Branches 39 39
=========================================
Hits 208 208 ☔ View full report in Codecov by Sentry. |
…the PSR step failing
fix: Update method of checking for approved runs to also account for the PSR step failing test: Allow testing � This is the commit message #3: test: Allow testing � This is the commit message #4: 0.0.1 Automatically generated by python-semantic-release � This is the commit message #5: Revert "test: Allow testing" This reverts commit 9c9a5cd.
Test Results (windows)
|
Test Results (ubuntu)
|
Test Results (macos)
|
Proposed changes
Previously, the repo's package-release workflow badge would go red (for a failure) if a deployment was rejected. Now the remainder of the jobs in the workflow will simply skip so that no changes are applied to the repo. This allows the workflow run history to be preserved while still allowing the badge to stay green.
Types of changes
What types of changes does your code introduce?
Put an
x
in the boxes that applyChecklist
Put an
x
in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.Addresses #<issue_number>