Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Seeking Feedback: Revise Instrument Examples README #59

Merged
merged 1 commit into from
Apr 13, 2024

Conversation

Brad-O
Copy link
Collaborator

@Brad-O Brad-O commented Apr 10, 2024

Pull Request Checklist

Please review the Contribution Guidelines before submitting.

  • You have previously submitted a Contributor License Agreement or have contacted a maintainer to request one.
  • You have given the Pull Request a descriptive name above.
  • You placed all files in an appropriate directory.
  • You updated README files if placing files in directories that already have READMEs.

Type (Select only one)

  • Bug fix
  • Working example
  • In-progress example (need Keithley help)
  • In-progress example (do not need Keithley help)
  • Other

Description

  • Would you like this change? Leave a comment on this PR either way!
  • This would change the README in the Instrument_Examples folder to only include the language contained therein.
  • Pro: this clarifies what languages are included as examples for each instrument
  • Con: the comments are often less descriptive for what the included examples do

@Brad-O Brad-O requested a review from Little-LIZard as a code owner April 10, 2024 21:39
@Little-LIZard Little-LIZard merged commit e8acb34 into main Apr 13, 2024
7 checks passed
@delete-merged-branch delete-merged-branch bot deleted the Model-Folder-Structure branch April 13, 2024 00:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants