Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Security errors fixed. #6

Closed

Conversation

ArunKumarTek
Copy link

@ArunKumarTek ArunKumarTek commented Sep 10, 2024

Proposed changes

Security issue fixed for two securities in the test server.
Resolved explicit and implicit return statement and removed redundant elif loop.
Addresses #< fill in issue number here >

Types of changes

What types of changes does your code introduce?
Put an x in the boxes that apply

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Functionality update (non-breaking change which updates or changes existing functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • CI/CD update (an update to the CI/CD workflows, scripts, and/or configurations)
  • Documentation update (an update to enhance the user experience when reading through the docs)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have followed the guidelines in the CONTRIBUTING document
  • I have signed the CLA
  • I have checked to ensure there aren't other open Pull Requests for the same update/change
  • I have created (or updated) an Issue to track the status of this update/change and updated the link in this PR description (see above in the Proposed changes section) using the wording Addresses #<issue_number>
  • I have performed a self-review of my code
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • Basic linting passes locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have added necessary documentation (if appropriate)
  • I have updated the Changelog with a brief description of my changes

@ArunKumarTek ArunKumarTek requested a review from a team as a code owner September 10, 2024 07:46
@CLAassistant
Copy link

CLAassistant commented Sep 10, 2024

CLA assistant check
All committers have signed the CLA.

@u625355
Copy link
Contributor

u625355 commented Sep 10, 2024

@ArunKumarTek , please sign the CLA.Contributor License Agreement

@u625355
Copy link
Contributor

u625355 commented Sep 10, 2024

Also, these changes haven't fixed security issues.

Signed-off-by: ArunKumarTek <[email protected]>
@nfelt14
Copy link
Collaborator

nfelt14 commented Sep 10, 2024

@ArunKumarTek please update the PR description.

Copy link
Contributor

@u625355 u625355 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving to check status of security issue, as it was not traceable in github actions for codeQL.

@nfelt14
Copy link
Collaborator

nfelt14 commented Sep 10, 2024

Please sign all commits

@ArunKumarTek
Copy link
Author

Closing this PR to raise again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants