-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch from print to logging #46
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tput should be controlled through the module-level loggers that will be added
nfelt14
temporarily deployed
to
package-build
November 12, 2024 18:56 — with
GitHub Actions
Inactive
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #46 +/- ##
==========================================
+ Coverage 77.66% 80.72% +3.06%
==========================================
Files 3 3
Lines 488 524 +36
Branches 106 94 -12
==========================================
+ Hits 379 423 +44
+ Misses 89 82 -7
+ Partials 20 19 -1 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
nfelt14
temporarily deployed
to
package-build
November 12, 2024 19:41 — with
GitHub Actions
Inactive
nfelt14
requested review from
amccann-Tek,
tekperson,
pradhanfortive and
qthompso
November 12, 2024 19:42
nfelt14
temporarily deployed
to
package-build
November 12, 2024 19:45 — with
GitHub Actions
Inactive
Breaking API Changes
|
Test Results (ubuntu)
|
Test Results (macos)
|
Test Results (windows)
|
qthompso
approved these changes
Nov 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
This switches TekHSI to use logging instead of normal printing. A new function,
configure_logging()
is provided so that users can configure what is being logged where. The default behavior keeps the stdout output very similar and adds a file log that contains all logging output.Types of changes
What types of changes does your code introduce?
Put an
x
in the boxes that applyChecklist
Put an
x
in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.Addresses #<issue_number>