Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Resolved some security issues flagged by CodeQL #4

Merged
merged 7 commits into from
Sep 9, 2024
Merged

fix: Resolved some security issues flagged by CodeQL #4

merged 7 commits into from
Sep 9, 2024

Conversation

u625355
Copy link
Contributor

@u625355 u625355 commented Sep 9, 2024

Proposed changes

Updated readthdocs link in README

Types of changes

What types of changes does your code introduce?
Put an x in the boxes that apply

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Functionality update (non-breaking change which updates or changes existing functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • CI/CD update (an update to the CI/CD workflows, scripts, and/or configurations)
  • Documentation update (an update to enhance the user experience when reading through the docs)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have followed the guidelines in the CONTRIBUTING document
  • I have signed the CLA
  • I have checked to ensure there aren't other open Pull Requests for the same update/change
  • I have created (or updated) an Issue to track the status of this update/change and updated the link in this PR description (see above in the Proposed changes section) using the wording Addresses #<issue_number>
  • I have performed a self-review of my code
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • Basic linting passes locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have added necessary documentation (if appropriate)
  • I have updated the Changelog with a brief description of my changes

@u625355 u625355 requested a review from a team as a code owner September 9, 2024 06:00
Removed duplicate imports.
Prefixed unused term for unused global variables.

Signed-off-by: Shashank P <[email protected]>
@u625355 u625355 changed the title Update README.md with readthedocs link fix: Resolved some security issues flagged by CodeQL Sep 9, 2024
src/tekhsi/tek_hsi_connect.py Outdated Show resolved Hide resolved
nfelt14
nfelt14 previously approved these changes Sep 9, 2024
@u625355 u625355 requested a review from nfelt14 September 9, 2024 15:42
@nfelt14 nfelt14 merged commit a760e0b into tektronix:main Sep 9, 2024
42 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants