Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Default Informers setup to Event Listener Sink #1584

Merged
merged 1 commit into from
Apr 25, 2023
Merged

Add Default Informers setup to Event Listener Sink #1584

merged 1 commit into from
Apr 25, 2023

Conversation

miguelvalerio
Copy link
Contributor

Changes

Add DefaultInformers setup to EventListenerSink. This overwrites the previously registered DynamicInformers.
Since DynamicInformers do not cache results, this caused a lot of throttling by the Kubernetes API in setups that had a lot of resources associated with an EventListener, as reported in #1284

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

  • Includes tests (if functionality changed/added)
  • Includes docs (if user facing)
  • Commit messages follow commit message best practices
  • Release notes block has been filled in or deleted (only if no user facing changes)

See the contribution guide for more details.

Release Notes

Kubernetes API requests performed by EventListeners are now cached.

@tekton-robot tekton-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Apr 22, 2023
@tekton-robot tekton-robot requested review from dlorenc and ncskier April 22, 2023 21:57
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Apr 22, 2023 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

@tekton-robot tekton-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 22, 2023
@tekton-robot
Copy link

Hi @miguelvalerio. Thanks for your PR.

I'm waiting for a tektoncd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@miguelvalerio miguelvalerio marked this pull request as ready for review April 22, 2023 22:03
@tekton-robot tekton-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 22, 2023
@tekton-robot tekton-robot requested review from bobcatfish and khrm April 22, 2023 22:03
@dibyom
Copy link
Member

dibyom commented Apr 24, 2023

/ok-to-test

@tekton-robot tekton-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 24, 2023
@dibyom
Copy link
Member

dibyom commented Apr 24, 2023

/ok-to-test

@tekton-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dibyom

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 24, 2023
khrm
khrm reviewed Apr 25, 2023
View reviewed changes
Copy link
Contributor

@khrm khrm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 25, 2023
@tekton-robot tekton-robot merged commit 679d811 into tektoncd:main Apr 25, 2023
@savitaashture savitaashture added this to the Triggers v0.24 milestone May 3, 2023
@khrm khrm mentioned this pull request May 11, 2023
Closed
khrm
khrm reviewed May 11, 2023
View reviewed changes
Copy link
Contributor

@khrm khrm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/kind bug

@tekton-robot tekton-robot added the kind/bug Categorizes issue or PR as related to a bug. label May 11, 2023
khrm added a commit to khrm/triggers that referenced this pull request Jun 5, 2023
@khrm
Fix k8s Events generation
8b1ef91 
After pr tektoncd#1584, k8s events is not coming. This fixes that by
adding v1beta1 and v1alpha1 apis to scheme.
@khrm khrm mentioned this pull request Jun 5, 2023
Merged
7 tasks
khrm added a commit to khrm/triggers that referenced this pull request Jun 5, 2023
@khrm
Fix k8s Events generation
4e13daa 
After pr tektoncd#1584, k8s events is not coming. This fixes that by
adding v1beta1 and v1alpha1 apis to scheme.
tekton-robot pushed a commit that referenced this pull request Jun 6, 2023
@khrm @tekton-robot
Fix k8s Events generation
3f3ec02 
After pr #1584, k8s events is not coming. This fixes that by
adding v1beta1 and v1alpha1 apis to scheme.
tekton-robot pushed a commit to tekton-robot/triggers that referenced this pull request Jun 6, 2023
@khrm
Fix k8s Events generation
1c9a4fd 
After pr tektoncd#1584, k8s events is not coming. This fixes that by
adding v1beta1 and v1alpha1 apis to scheme.
tekton-robot pushed a commit that referenced this pull request Jun 6, 2023
@khrm @tekton-robot
Fix k8s Events generation
bbb3073 
After pr #1584, k8s events is not coming. This fixes that by
adding v1beta1 and v1alpha1 apis to scheme.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@khrm khrm khrm left review comments

@dibyom dibyom dibyom approved these changes

@dlorenc dlorenc Awaiting requested review from dlorenc

@ncskier ncskier Awaiting requested review from ncskier

@bobcatfish bobcatfish Awaiting requested review from bobcatfish

Assignees

@khrm khrm

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
Triggers v0.24
Development

Successfully merging this pull request may close these issues.
5 participants
@miguelvalerio @tekton-robot @dibyom @khrm @savitaashture