Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove PipelineResource support and bump pipeline to 0.46.0 #1577

Merged
merged 1 commit into from
Apr 20, 2023
Merged

Remove PipelineResource support and bump pipeline to 0.46.0 #1577

merged 1 commit into from
Apr 20, 2023

Conversation

pratap0007
Copy link
Contributor

@pratap0007 pratap0007 commented Apr 17, 2023 •
edited
Loading

This patch will remove PipelineResource and
it's all occurrence and also bump pipeline to 0.46.0
and add Swagger.json for Triggers with Pipelines v0.46

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

  • Includes tests (if functionality changed/added)
  • Includes docs (if user facing)
  • Commit messages follow commit message best practices
  • Release notes block has been filled in or deleted (only if no user facing changes)

Release Notes

This will remove PipelineResource and it's all occurrence and also bump pipeline to 0.46.0 
and add Swagger.json for Triggers with Pipelines v0.46

@tekton-robot tekton-robot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Apr 17, 2023
@tekton-robot tekton-robot requested review from ncskier and vtereso April 17, 2023 11:50
@tekton-robot tekton-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Apr 17, 2023
khrm
khrm reviewed Apr 17, 2023
View reviewed changes
Copy link
Contributor

@khrm khrm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 17, 2023
@khrm
Copy link
Contributor

khrm commented Apr 17, 2023

/kind cleanup

@tekton-robot tekton-robot added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Apr 17, 2023
@tekton-robot
Copy link

The following is the coverage report on the affected files.
Say /test pull-tekton-triggers-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/config/allowed_types.go 77.8% 75.0% -2.8
pkg/resources/create.go 81.2% 47.9% -33.3

@tekton-robot tekton-robot removed the lgtm Indicates that a PR is ready to be merged. label Apr 17, 2023
@tekton-robot
Copy link

The following is the coverage report on the affected files.
Say /test pull-tekton-triggers-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/config/allowed_types.go 77.8% 75.0% -2.8
pkg/resources/create.go 81.2% 47.9% -33.3

@tekton-robot
Copy link

The following is the coverage report on the affected files.
Say /test pull-tekton-triggers-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/config/allowed_types.go 77.8% 75.0% -2.8

@tekton-robot
Copy link

The following is the coverage report on the affected files.
Say /test pull-tekton-triggers-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/config/allowed_types.go 77.8% 75.0% -2.8

@pratap0007
Copy link
Contributor Author

/test pull-tekton-triggers-build-tests

@khrm
Copy link
Contributor

khrm commented Apr 19, 2023 •
edited
Loading

We need to get this pr merged #1578 to fix errors during build tests.
@pratap0007

@dibyom
Copy link
Member

dibyom commented Apr 19, 2023

Looks good to me - thanks @pratap0007

I'd suggest squashing the two commits and then I think we are good to merge.

/approve

@tekton-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dibyom

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 19, 2023
@pratap0007
Remove PipelineResource support and bump pipeline to 0.46.0
dab36fd 
This patch will remove PipelineResource and
it's all occurrence and also bump pipeline to 0.46.0
and add Swagger.json for Triggers with Pipelines v0.46

Signed-off-by: Shiv Verma <[email protected]>
@tekton-robot
Copy link

The following is the coverage report on the affected files.
Say /test pull-tekton-triggers-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/config/allowed_types.go 77.8% 75.0% -2.8

khrm
khrm reviewed Apr 20, 2023
View reviewed changes
Copy link
Contributor

@khrm khrm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 20, 2023
@tekton-robot tekton-robot merged commit bf60312 into tektoncd:main Apr 20, 2023
@savitaashture savitaashture added this to the Triggers v0.24 milestone May 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@savitaashture savitaashture savitaashture left review comments

@dibyom dibyom dibyom left review comments

@khrm khrm khrm left review comments

@ncskier ncskier Awaiting requested review from ncskier

@vtereso vtereso Awaiting requested review from vtereso

Assignees

@khrm khrm

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
Triggers v0.24
Development

Successfully merging this pull request may close these issues.
5 participants
@pratap0007 @khrm @tekton-robot @dibyom @savitaashture