Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding Minimum Kubernetes version #1560

Merged
merged 1 commit into from
Mar 15, 2023
Merged

Adding Minimum Kubernetes version #1560

merged 1 commit into from
Mar 15, 2023

Conversation

khrm
Copy link
Contributor

@khrm khrm commented Mar 14, 2023 •
edited
Loading

Adding Minimum Kubernetes version to releases page.

Changes

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

  • Includes tests (if functionality changed/added)
  • Includes docs (if user facing)
  • Commit messages follow commit message best practices
  • Release notes block has been filled in or deleted (only if no user facing changes)

See the contribution guide for more details.

Release Notes

NONE

@khrm
Adding Minimum Kubernetes version
3430309 
Adding Minimum Kubernetes version to releases
page.
@tekton-robot tekton-robot added the release-note-none Denotes a PR that doesnt merit a release note. label Mar 14, 2023
@tekton-robot tekton-robot requested review from ncskier and wlynch March 14, 2023 07:36
@tekton-robot tekton-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 14, 2023
khrm
khrm commented Mar 14, 2023
View reviewed changes
Copy link
Contributor Author

@khrm khrm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/kind misc

@tekton-robot tekton-robot added the kind/misc Categorizes issue or PR as a miscellaneuous one. label Mar 14, 2023
@khrm
Copy link
Contributor Author

khrm commented Mar 15, 2023

/assign @dibyom

dibyom
dibyom approved these changes Mar 15, 2023
View reviewed changes
Copy link
Member

@dibyom dibyom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 15, 2023
@tekton-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dibyom

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 15, 2023
@tekton-robot tekton-robot merged commit d54faeb into main Mar 15, 2023
@khrm khrm deleted the khrm-patch-3 branch August 23, 2023 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dibyom dibyom dibyom approved these changes

@ncskier ncskier Awaiting requested review from ncskier

@wlynch wlynch Awaiting requested review from wlynch

Assignees

@dibyom dibyom

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/misc Categorizes issue or PR as a miscellaneuous one. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesnt merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@khrm @tekton-robot @dibyom