Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix go1.19 related codegen issues #1534

Merged
merged 5 commits into from
Feb 23, 2023
Merged

Fix go1.19 related codegen issues #1534

merged 5 commits into from
Feb 23, 2023

Conversation

khrm
Copy link
Contributor

@khrm khrm commented Feb 22, 2023 •
edited
Loading

Updated code by running ./hack/codegen.sh with go1.19. Needed for passing tests.

Changes

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

  • Includes tests (if functionality changed/added)
  • Includes docs (if user facing)
  • Commit messages follow commit message best practices
  • Release notes block has been filled in or deleted (only if no user facing changes)

See the contribution guide for more details.

Release Notes

NONE

@tekton-robot tekton-robot added the release-note-none Denotes a PR that doesnt merit a release note. label Feb 22, 2023
@tekton-robot tekton-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Feb 22, 2023
khrm
khrm commented Feb 22, 2023
View reviewed changes
Copy link
Contributor Author

@khrm khrm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/kind misc

@tekton-robot tekton-robot added the kind/misc Categorizes issue or PR as a miscellaneuous one. label Feb 22, 2023
@khrm
Copy link
Contributor Author

khrm commented Feb 23, 2023

We are facing a chicken and egg issue. I would have to add those by pr by @my-git9 here.

@tekton-robot tekton-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 23, 2023
@khrm
Fix go1.19 related codegen issues
c834703 
Updated code by running ./hack/codegen.sh with go1.19. Needed for
passing the tests.
@tekton-robot tekton-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 23, 2023
@tekton-robot
Copy link

The following is the coverage report on the affected files.
Say /test pull-tekton-triggers-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/interceptors/server/server.go 79.3% 83.3% 4.1

This was referenced Feb 23, 2023
Closed
Closed
Closed
@khrm
Copy link
Contributor Author

khrm commented Feb 23, 2023 •
edited
Loading

@my-git9 I have added your commits here. #1534
CI tests are failing and we needed all ioutil changes along with generated code change.

@khrm khrm requested a review from savitaashture February 23, 2023 17:10
dibyom
dibyom approved these changes Feb 23, 2023
View reviewed changes
Copy link
Member

@dibyom dibyom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 23, 2023
@tekton-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dibyom

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 23, 2023
@tekton-robot tekton-robot merged commit 4bb9457 into tektoncd:main Feb 23, 2023
@khrm khrm mentioned this pull request Feb 27, 2023
Closed
@khrm khrm deleted the f/go1.19 branch February 28, 2023 04:23
@khrm
Copy link
Contributor Author

khrm commented Feb 28, 2023

Fixes #1495 also

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dibyom dibyom dibyom approved these changes

@vtereso vtereso Awaiting requested review from vtereso

@savitaashture savitaashture Awaiting requested review from savitaashture

Assignees

@dibyom dibyom

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/misc Categorizes issue or PR as a miscellaneuous one. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesnt merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@khrm @tekton-robot @dibyom @my-git9