Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump ko version to v0.6.0 #600

Merged
merged 1 commit into from
Oct 13, 2020
Merged

Bump ko version to v0.6.0 #600

merged 1 commit into from
Oct 13, 2020

Conversation

barthy1
Copy link
Member

@barthy1 barthy1 commented Oct 2, 2020

Bump ko version to be able to use new --platform=all feature to build multi-arch images.
Part of work to build multi-arch Tekton images using --platform=all, see tektoncd/pipeline#3314

Verified that pipeline, triggers, operator and dashboard use now ko:// prefix, as for v0.6.0 it's a requirement.

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

See the contribution guide
for more details.

@barthy1
Bump ko version to v0.6.0
f6fabce 
Bump ko version to be able to use new "--platform=all" feature to build
multi-arch images with ko.

Signed-off-by: Yulia Gaponenko <[email protected]>
@tekton-robot tekton-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Oct 2, 2020
@tekton-robot
Copy link
Contributor

Hi @barthy1. Thanks for your PR.

I'm waiting for a tektoncd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tekton-robot tekton-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 2, 2020
@vdemeester vdemeester mentioned this pull request Oct 2, 2020
Closed
@savitaashture
Copy link
Contributor

/ok-to-test

@tekton-robot tekton-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 5, 2020
@savitaashture
Copy link
Contributor

/test check-pr-has-kind-label

@savitaashture
Copy link
Contributor

/test plumbing-test-runner-build

@savitaashture
Copy link
Contributor

/test plumbing-ko-gcloud-build

@savitaashture
Copy link
Contributor

/test check-pr-has-kind-label

@vdemeester
Copy link
Member

/kind misc
/test .*

@tekton-robot tekton-robot added the kind/misc Categorizes issue or PR as a miscellaneuous one. label Oct 5, 2020
@dibyom dibyom added kind/misc Categorizes issue or PR as a miscellaneuous one. and removed kind/misc Categorizes issue or PR as a miscellaneuous one. labels Oct 12, 2020
@dibyom
Copy link
Member

dibyom commented Oct 13, 2020

/test plumbing-golang-lint

vdemeester
vdemeester approved these changes Oct 13, 2020
View reviewed changes
Copy link
Member

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/meow

@tekton-robot
Copy link
Contributor

@vdemeester: cat image

In response to this:

/meow

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tekton-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 13, 2020
@dibyom
Copy link
Member

dibyom commented Oct 13, 2020

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 13, 2020
@tekton-robot tekton-robot merged commit 58185fa into tektoncd:master Oct 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vdemeester vdemeester vdemeester approved these changes

@afrittoli afrittoli Awaiting requested review from afrittoli

@dlorenc dlorenc Awaiting requested review from dlorenc

Assignees

@dibyom dibyom

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/misc Categorizes issue or PR as a miscellaneuous one. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@barthy1 @tekton-robot @savitaashture @vdemeester @dibyom