Skip to content

Commit

Permalink
Stop using $(uid) for resource names in templates
Browse files Browse the repository at this point in the history
Triggers v0.12.0 changed the event UID form a short string to
a UUID. Do not use $(uid) anymore in resource names as it creates
invalid names.

Signed-off-by: Andrea Frittoli <[email protected]>
  • Loading branch information
afrittoli authored and tekton-robot committed Mar 9, 2021
1 parent 7c03c77 commit 007ce03
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion tekton/ci-workspace/community/template.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ spec:
- apiVersion: tekton.dev/v1beta1
kind: PipelineRun
metadata:
name: pull-community-teps-lint-$(uid)
generateName: pull-community-teps-lint-
labels:
prow.k8s.io/build-id: $(tt.params.buildUUID)
tekton.dev/kind: ci
Expand Down
2 changes: 1 addition & 1 deletion tekton/mario-bot/mario-github-comment.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ spec:
- apiVersion: tekton.dev/v1beta1
kind: TaskRun
metadata:
generateName: mario-comment-github-$(uid)-
generateName: mario-comment-github-
spec:
serviceAccountName: mario-listener
taskSpec:
Expand Down
2 changes: 1 addition & 1 deletion tekton/mario-bot/mario-image-build-trigger.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -155,7 +155,7 @@ spec:
- apiVersion: tekton.dev/v1beta1
kind: TaskRun
metadata:
generateName: build-and-push-$(uid)-
generateName: build-and-push-
labels:
prow.k8s.io/build-id: $(tt.params.buildUUID)
mario.bot/pull-request-id: $(tt.params.pullRequestID)
Expand Down

0 comments on commit 007ce03

Please sign in to comment.