fix build uncorrect status #801
Conversation
googlebot
added
the
cla: yes
tekton-robot
added
size/XS
|
/ok-to-test |
tekton-robot
removed
the
needs-ok-to-test
|
Thanks for the PR! I left one comment about grammar in the logging message, otherwise this looks good to me. Would you also mind adding a bit more to the commit message explaining the change and how we get into this state? |
|
@dlorenc got it. |
| @@ -167,6 +167,10 @@ func (c *Reconciler) Reconcile(ctx context.Context, key string) error { | |||
| pr := original.DeepCopy() | |||
| if !pr.HasStarted() { | |||
| pr.Status.InitializeConditions() | |||
| if pr.Status.StartTime.Sub(pr.CreationTimestamp.Time) < 0 { | |||
| c.Logger.Warnf("Now PipelineRun %s createTimestamp abnormal higher than startTime which create at %s, start at %s", pr.GetRunKey(), pr.CreationTimestamp, pr.Status.StartTime) | |||
There was a problem hiding this comment.
grammar nit: could you change this logging statement to something like:
PipelineRun creationTimestamp %s is after the pipelineRun started %s. Setting them equal.
Sorry, somehow I never sent the comment itself. Just sent! |
Signed-off-by: Zou Nengren <[email protected]>
tekton-robot
added
size/S
|
/lgtm /approve Thanks! |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vdemeester, zouyee The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
the
approved
Fixes knative/build#599
Proposed Changes
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide
for more details.
Release Notes