Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-v0.47.x] don't return validation error when final tasks failed/skipped #7487

Merged
merged 2 commits into from
Jan 3, 2024

Conversation

vdemeester
Copy link
Member

@vdemeester vdemeester commented Dec 13, 2023

Changes

Cherry-pick for 0.47.x of 7407

This commit closes #6139, in previous fix PR:
#6395, only dagTasks statuses are considered and final tasks are missing. This PR fixes this.

Signed-off-by: Yongxuan Zhang [email protected] (cherry picked from commit 7c040de)

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • Has Docs if any changes are user facing, including updates to minimum requirements e.g. Kubernetes version bumps
  • Has Tests included if any functionality added or changed
  • Follows the commit message standard
  • Meets the Tekton contributor standards (including functionality, content, code)
  • Has a kind label. You can add one by adding a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
  • Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings). See some examples of good release notes.
  • Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes

NONE

/cc @Yongxuanzhang @chitrangpatel @QuanZhang-William

@tekton-robot tekton-robot added the release-note-none Denotes a PR that doesnt merit a release note. label Dec 13, 2023
@vdemeester
Copy link
Member Author

/kind bug

@tekton-robot tekton-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. kind/bug Categorizes issue or PR as related to a bug. labels Dec 13, 2023
This commit closes tektoncd#6139, in previous fix PR:
tektoncd#6395, only dagTasks statuses
are considered and final tasks are missing. This PR fixes this.

Signed-off-by: Yongxuan Zhang [email protected]
(cherry picked from commit 7c040de)
Signed-off-by: Vincent Demeester <[email protected]>
@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/pipeline/v1beta1/customrun_types.go 60.0% 56.7% -3.3
pkg/apis/pipeline/v1beta1/taskrun_types.go 82.3% 77.2% -5.1
pkg/reconciler/pipelinerun/pipelinerun.go 92.2% 89.2% -3.0

@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/pipeline/v1beta1/customrun_types.go 60.0% 56.7% -3.3
pkg/apis/pipeline/v1beta1/taskrun_types.go 82.3% 77.2% -5.1
pkg/reconciler/pipelinerun/pipelinerun.go 92.2% 89.2% -3.0

Add some missing functions.

Signed-off-by: Vincent Demeester <[email protected]>
@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/pipeline/v1beta1/customrun_types.go 60.0% 56.7% -3.3
pkg/apis/pipeline/v1beta1/taskrun_types.go 82.3% 77.2% -5.1
pkg/reconciler/pipelinerun/pipelinerun.go 92.2% 89.2% -3.0
pkg/reconciler/pipelinerun/resources/pipelinerunresolution.go 96.7% 94.8% -1.8
pkg/reconciler/pipelinerun/resources/pipelinerunstate.go 99.5% 99.5% -0.0

@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/pipeline/v1beta1/customrun_types.go 60.0% 56.7% -3.3
pkg/apis/pipeline/v1beta1/taskrun_types.go 82.3% 77.2% -5.1
pkg/reconciler/pipelinerun/pipelinerun.go 92.2% 89.2% -3.0
pkg/reconciler/pipelinerun/resources/pipelinerunresolution.go 96.7% 94.8% -1.8
pkg/reconciler/pipelinerun/resources/pipelinerunstate.go 99.5% 99.5% -0.0

@tekton-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abayer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 3, 2024
@chitrangpatel
Copy link
Contributor

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 3, 2024
@tekton-robot tekton-robot merged commit 37920b1 into tektoncd:release-v0.47.x Jan 3, 2024
10 checks passed
@vdemeester vdemeester deleted the cherry-pick-7407 branch January 3, 2024 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesnt merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants