-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat:support to extract failed task results #5750
Conversation
Hi @cugykw. Thanks for your PR. I'm waiting for a tektoncd member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/kind feature |
/ok-to-test |
The following is the coverage report on the affected files.
|
if !referencedPipelineTask.isSuccessful() && !referencedPipelineTask.isFailure() { | ||
return nil, resultRef.PipelineTask, fmt.Errorf("task %q referenced by result was not successful and not failure", referencedPipelineTask.PipelineTask.Name) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What other status could it be ? Maybe the text should say "not finished (success or failure)", or something like that ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What other status could it be ? Maybe the text should say "not finished (success or failure)", or something like that ?
Good suggestion, I have adjusted. Thanks.
5df7cff
to
a69adff
Compare
The following is the coverage report on the affected files.
|
/assign |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: chitrangpatel The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
a69adff
to
e1e08df
Compare
The following is the coverage report on the affected files.
|
The following is the coverage report on the affected files.
|
e1e08df
to
6921eb5
Compare
The following is the coverage report on the affected files.
|
The following is the coverage report on the affected files.
|
@cugykw: PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Changes
If the task fails or succeeds, as long as the task result is output, it can be successfully parsed and can be referenced by the fianl task.
This commit will enable the failed task to parse the task results, and the final task can reference it.
Please see detailed description: #5749
Submitter Checklist
As the author of this PR, please check off the items in this checklist:
functionality, content, code)
/kind <type>
. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tepRelease Notes