[TEP-0089] Apis to handle SPIRE signing and verification.

[jagathprakash]

Changes

Breaking down PR #4759 originally proposed by @pxp928 to address TEP-0089
according @lumjjb suggestions.
Plan for breaking down PR is
PR 1.1: api
PR 1.2: entrypointer (+cmd line + test/entrypointer)
Entrypoint takes results and signs the results (termination message).
PR 1.3: reconciler + pod + cmd/controller + integration tests
Controller will verify the signed result.

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

• Has Docs included if any changes are user facing
• Has Tests included if any functionality added or changed
• Follows the commit message standard
• Meets the Tekton contributor standards (including
  functionality, content, code)
• Has a kind label. You can add one by adding a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
• Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings)
• Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes

NONE

[tekton-robot]

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

[jagathprakash]

/assign @pxp928

[tekton-robot]

@jagathprakash: GitHub didn't allow me to assign the following users: pxp928.

Note that only tektoncd members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

/assign @pxp928

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[jagathprakash]

/assign @pxp928

[tekton-robot]

@jagathprakash: GitHub didn't allow me to assign the following users: pxp928.

Note that only tektoncd members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

/assign @pxp928

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[jagathprakash]

/assign @lumjjb

[tekton-robot]

@jagathprakash: GitHub didn't allow me to assign the following users: lumjjb.

Note that only tektoncd members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

/assign @lumjjb

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[jagathprakash]

/assign @lumjjb

[tekton-robot]

@jagathprakash: GitHub didn't allow me to assign the following users: lumjjb.

Note that only tektoncd members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

/assign @lumjjb

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[pxp928]

Thanks @jagathprakash. Not sure why its not assigning me as I am part of the tektoncd members.

[jagathprakash]

Thanks @jagathprakash. Not sure why its not assigning me as I am part of the tektoncd members.

@pxp928, @lumjjb I tried to assign both of you but could not. Please do take a look. Thanks!

[lumjjb]

This looks good!! Thanks @jagathprakash for helping to modularize the PR! I think it should be good to get out of draft?

[afrittoli]

@jagathprakash Thanks for your PR!
As you finalise the PR, could you remove the merge commits and make sure the PR is only made of one commit (two or three may also be ok, if needed). Thank you!

[jagathprakash]

@jagathprakash Thanks for your PR! As you finalise the PR, could you remove the merge commits and make sure the PR is only made of one commit (two or three may also be ok, if needed). Thank you!

Done. Thanks!

[tekton-robot]

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/config/feature_flags.go	78.9%	78.3%	-0.6
pkg/apis/pipeline/v1beta1/taskrun_types.go	76.9%	78.2%	1.3

[jagathprakash]

This looks good!! Thanks @jagathprakash for helping to modularize the PR! I think it should be good to get out of draft?

Removed out of draft.

[jagathprakash]

/kind feature

[tekton-robot]

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/config/feature_flags.go	78.9%	78.3%	-0.6
pkg/apis/pipeline/v1beta1/taskrun_types.go	76.9%	78.2%	1.3

[afrittoli]

Yay, thanks for this, looking forward to this feature!
/approve

[afrittoli]

NIT: The flag is not in the config map YAML under config/ and not in the docs, which makes sense since the feature is not available yet. Perhaps we could have a comment here saying that the feature is not yet available?

[jagathprakash]

This comment would be invalid in an immediate next PR. Will skip for now. Let me know if you feel strongly about it and I can add it.

[tekton-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: afrittoli

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• pkg/apis/OWNERS [afrittoli]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[dibyom]

/lgtm

[jagathprakash]

/retest