-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix v1 PipelineRun CRD conversionReviewVersions and conversion typo #5619
Conversation
2b3ff61
to
edb3c0f
Compare
edb3c0f
to
02935c7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Jerome! Can you please add a more descriptive PR title/commit message?
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lbernick, vdemeester The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
That said, doesn't it depend on #5579 ? (aka what happens if the conversion webhook has this v1 in its configuration but there is no v1 on the cluster ?) |
the v1 version exists, it just is not "served" by the API server yet. #5579 flips the bit to start serving our v1 version |
/lgtm |
Changes
This change adds the v1 conversionReviewVersion for v1 for pipelineRun CRD
and fixes the typo for pipelineRun conversion.
/kind bug
cc @lbernick
Submitter Checklist
As the author of this PR, please check off the items in this checklist:
functionality, content, code)
/kind <type>
. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tepRelease Notes