Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate ClusterTasks #5545

Merged
merged 1 commit into from
Oct 6, 2022
Merged

Deprecate ClusterTasks #5545

merged 1 commit into from
Oct 6, 2022

Conversation

lbernick
Copy link
Member

This commit marks ClusterTasks as deprecated, planned for the next Pipelines release.
Closes #4476.

/kind misc

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • Has Docs included if any changes are user facing
  • n/a Has Tests included if any functionality added or changed
  • Follows the commit message standard
  • Meets the Tekton contributor standards (including
    functionality, content, code)
  • Has a kind label. You can add one by adding a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
  • Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings)
  • Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes

Action required: ClusterTasks are deprecated. Please use the cluster resolver instead.

@tekton-robot tekton-robot added release-note-action-required Denotes a PR that introduces potentially breaking changes that require user action. kind/misc Categorizes issue or PR as a miscellaneuous one. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 22, 2022
@lbernick
Deprecate ClusterTasks
db8ffae 
This commit marks ClusterTasks as deprecated, planned for the next Pipelines release.
@abayer
Copy link
Contributor

abayer commented Sep 22, 2022

/approve

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 22, 2022
vdemeester
vdemeester approved these changes Sep 23, 2022
View reviewed changes
Copy link
Member

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/cc @tektoncd/core-maintainers

@tekton-robot tekton-robot requested a review from a team September 23, 2022 08:07
@tekton-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abayer, jerop, vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [abayer,jerop,vdemeester]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@afrittoli
Copy link
Member

Thanks @lbernick - this sounds good to me. The only thing is that I would hold on until the remote resolution feature gets out of alpha. I know @abayer has a PR up for that, but in my opinion, we should gain some user experience on remote resolution before promoting it to beta.

@lbernick
Copy link
Member Author

Thanks Andrea!
/hold until RR PR is resolved

@tekton-robot tekton-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 23, 2022
@jerop jerop self-assigned this Sep 27, 2022
@lbernick lbernick added this to the Pipelines v0.41 milestone Oct 4, 2022
@lbernick
Copy link
Member Author

lbernick commented Oct 6, 2022

/hold cancel
since we've promoted remote resolution to beta

@tekton-robot tekton-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 6, 2022
jerop
jerop reviewed Oct 6, 2022
View reviewed changes
Copy link
Member

@jerop jerop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 6, 2022
@tekton-robot tekton-robot merged commit bd8d79d into tektoncd:main Oct 6, 2022
@lbernick lbernick mentioned this pull request Dec 22, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jerop jerop jerop approved these changes

@vdemeester vdemeester vdemeester approved these changes

@afrittoli afrittoli Awaiting requested review from afrittoli

@dibyom dibyom Awaiting requested review from dibyom

Assignees

@jerop jerop

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/misc Categorizes issue or PR as a miscellaneuous one. lgtm Indicates that a PR is ready to be merged. release-note-action-required Denotes a PR that introduces potentially breaking changes that require user action. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
Pipelines v0.41
Development

Successfully merging this pull request may close these issues.

Where should we take ClusterTasks next?
6 participants
@lbernick @abayer @tekton-robot @afrittoli @vdemeester @jerop