-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TEP-0114: Updating runs.md Documentation #5390
Conversation
Prior to this commit, the previous iteration of the runs.md doc had some fields missing from the API and the level of detail and clarification. In this commit, we aim to clarify the API and update it to make sure it is clear, upto date, and has useful examples. Fixes issue [tektoncd#5158](tektoncd#5158) /cc @jerop /kind documentation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Hi @vsinghai. Thanks for your PR. I'm waiting for a tektoncd member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/hold |
/ok-to-test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Varun! This is great to have, but I don't think we should close #5158 when this is merged (I think "fixes #" in your PR description will result in that happening).
I think there's a lot more documentation for runs that would be nice to have, such as realistic examples of ci/cd pipelines containing runs and links to useful existing custom tasks. @jerop maybe worth updating the issue with some ideas, and possibly @geriom you might have some thoughts here as well? Might be out of scope for this PR-- I can see in the PR description you're planning to add some examples?
@@ -54,12 +54,16 @@ A `Run` definition supports the following fields: | |||
- Optional: | |||
- [`params`](#specifying-parameters) - Specifies the desired execution | |||
parameters for the custom task. | |||
- [`status`](#) - Used for cancelling a `Run`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think a few of these links are broken.
@@ -54,12 +54,16 @@ A `Run` definition supports the following fields: | |||
- Optional: | |||
- [`params`](#specifying-parameters) - Specifies the desired execution | |||
parameters for the custom task. | |||
- [`status`](#) - Used for cancelling a `Run`. | |||
- [`statusMessage`](#) - Status message for cancellation. | |||
- [`retries`](#) - Specifies propagating retries count to custom tasks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- [`retries`](#) - Specifies propagating retries count to custom tasks. | |
- [`retries`](#) - Specifies the number of times the `Run` should retry, if the custom task controller supports retries. |
Thanks for the feedback @lbernick! There is still currently a lot that I have left to do for this PR, including (but not limited to) having examples for the custom fields and providing more clarity to the API. The reason I created a PR was so that @jerop can just look over the incremental progress that I am making to make sure we are on the same path regarding how to fix #5158, and is also why I have the PR on |
no problem, thanks for the explanation! I think creating a draft PR can be useful in situations like these- it lets reviewers know that it's still a WIP (hold does this to some extent but I wasn't sure why the PR was on hold) |
Issues go stale after 90d of inactivity. /lifecycle stale Send feedback to tektoncd/plumbing. |
Changes
Prior to this commit, the previous iteration
of the runs.md doc had some fields missing from
the API and the level of detail and clarification.
In this commit, we aim to clarify the API and update
it to make sure it is clear, upto date, and has useful
examples.
Fixes issue #5158
/cc @jerop
/kind documentation
Submitter Checklist
As the author of this PR, please check off the items in this checklist:
functionality, content, code)
/kind <type>
. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tepRelease Notes