Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unscheduled Runs shouldn't be included in full status #5287

Merged
merged 1 commit into from
Aug 9, 2022
Merged

Unscheduled Runs shouldn't be included in full status #5287

merged 1 commit into from
Aug 9, 2022

Commits on Aug 9, 2022

  1. Unscheduled Runs shouldn't be included in full status 

    Fixes tektoncd#5282

When removing conditions, I accidentally made `GetRunsStatus` not skip including custom task `ResolvedPipelineTask`s without `Run`s in the `PipelineRun.Status.Runs` map. This resulted in cancellation failing, because the cancellation logic tries to patch each `Run` or `TaskRun` in the `PipelineRun` status (either in the `Runs` and `TaskRuns` maps for full embedded status, or `ChildReferences` for minimal or both embedded status). Unscheduled `PipelineTask`s for `Task`s were already properly excluded from the status map, and `ChildReferences` was fine either way, but due to the oversight I mentioned above, unscheduled `PipelineTask`s for custom tasks _were_ included in the full embedded status map, and cancellation would error due to that.

Signed-off-by: Andrew Bayer <[email protected]>
    @abayer
    abayer committed Aug 9, 2022
    Configuration menu
    Copy the full SHA
    3b93c23 View commit details
    Browse the repository at this point in the history