Publish Pipeline Results from successful TaskRuns in Failed PipelineRuns

[QuanZhang-William]

Changes

Publish Pipeline Results from successful TaskRuns in Failed PipelineRuns: #3749

Prior to this change a failed PipelineRun does not emit any PipelineResult even when some PipelineTasks referenced by the PipelineResult succeeded. This commit changes to publish Pipeline Results only from successful PipelineTaskRuns in the failed PipelineRun

Such Results are valid because they are generated by successful TaskRuns. They can provide more context and successful artifacts to users of the partially successful PipelinRun.

/kind feature

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

• Docs included if any changes are user facing
• Tests included if any functionality added or changed
• Follows the commit message standard
• Meets the Tekton contributor standards (including
  functionality, content, code)
• Release notes block below has been filled in
  (if there are no user facing changes, use release note "NONE")

Release Notes

Pipeline results are now initialized even when a pipelineRun fails. The task results from all the successful tasks are propagated to the pipelineRun.

[linux-foundation-easycla]

The committers listed above are authorized under a signed CLA.

• ✅ login: QuanZhang-William (7190b15)

[tekton-robot]

Hi @QuanZhang-William. Thanks for your PR.

I'm waiting for a tektoncd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[jerop]

Note that this is solving the first problem only as discussed in the API WG on 06/27:

"Publishing PipelineResults from successful TaskRuns in Failed PipelineRuns"

@QuanZhang-William please update the commit and pull request description to make this clear

[QuanZhang-William]

/retest

[tekton-robot]

@QuanZhang-William: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[tekton-robot]

@QuanZhang-William: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[ywluogg]

/ok-to-test

[tekton-robot]

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/reconciler/pipelinerun/pipelinerun.go	86.2%	86.3%	0.2

[abayer]

/retest

[QuanZhang-William]

/retest

[tekton-robot]

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/reconciler/pipelinerun/pipelinerun.go	86.2%	86.3%	0.2

[QuanZhang-William]

/retest

[tekton-robot]

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/reconciler/pipelinerun/pipelinerun.go	86.2%	86.3%	0.2

[jerop]

@QuanZhang-William thank you - we need the same information in the commit message too https://github.com/tektoncd/community/blob/main/standards.md#commits

[QuanZhang-William]

@QuanZhang-William thank you - we need the same information in the commit message too https://github.com/tektoncd/community/blob/main/standards.md#commits

@QuanZhang-William thank you - we need the same information in the commit message too https://github.com/tektoncd/community/blob/main/standards.md#commits

Oops, updated commit message as well

[tekton-robot]

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/reconciler/pipelinerun/pipelinerun.go	86.2%	86.3%	0.2

[tekton-robot]

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/reconciler/pipelinerun/pipelinerun.go	86.2%	86.3%	0.2

[lbernick]

/lgtm

[tekton-robot]

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/reconciler/pipelinerun/pipelinerun.go	86.2%	86.3%	0.2

[QuanZhang-William]

/retest

[tekton-robot]

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/reconciler/pipelinerun/pipelinerun.go	86.2%	86.3%	0.2

[pritidesai]

I am very excited for this feature, thank you @QuanZhang-William for implementing this 🙏

@jerop, @lbernick please make sure to have the release notes updated for PRs implementing features. This is a direct user facing change, the users will start seeing pipelineResults even when their pipeline fails. @jerop please make sure to capture this in the 0.38 release notes.

[pritidesai]

I updated the comment in this PR description!