Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TEP-0075: Object variable replacement on Pipeline/PipelineRun level #5007

Merged
merged 1 commit into from
Jun 29, 2022
Merged

TEP-0075: Object variable replacement on Pipeline/PipelineRun level #5007

merged 1 commit into from
Jun 29, 2022

Conversation

chuangw6
Copy link
Member

@chuangw6 chuangw6 commented Jun 21, 2022 •
edited
Loading

Changes

Replace the following references with actual value

  • the reference to the whole object param defined in PipelineSpec
  • the reference to the individual keys of an object param

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • Docs included if any changes are user facing
  • Tests included if any functionality added or changed
  • Follows the commit message standard
  • Meets the Tekton contributor standards (including
    functionality, content, code)
  • Release notes block below has been filled in
    (if there are no user facing changes, use release note "NONE")

Release Notes

Added object variable replacements to support following use cases
- use the reference of the whole object param to provide value for PipelineTask param
- use the reference of object individual variables to provide value for any field that accepts string

note: similar to array, object param is not supported in matrix.

@tekton-robot tekton-robot added the do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. label Jun 21, 2022
@tekton-robot tekton-robot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Jun 21, 2022
@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/pipeline/v1beta1/param_types.go 97.4% 93.8% -3.7

@chuangw6 chuangw6 force-pushed the pipelinerun-var-replacement branch from 43790b9 to 9c5d462 Compare June 21, 2022 15:44
@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/pipeline/v1beta1/param_types.go 97.4% 93.8% -3.7

@chuangw6 chuangw6 force-pushed the pipelinerun-var-replacement branch from 9c5d462 to c8e342a Compare June 21, 2022 15:54
@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/pipeline/v1beta1/param_types.go 97.4% 97.9% 0.5

@chuangw6 chuangw6 force-pushed the pipelinerun-var-replacement branch from c8e342a to 4ceb2d8 Compare June 21, 2022 16:07
@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/pipeline/v1beta1/param_types.go 97.4% 97.9% 0.5

@chuangw6
Copy link
Member Author

/test pull-tekton-pipeline-alpha-integration-tests

@tekton-robot tekton-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Jun 21, 2022
@chuangw6
Copy link
Member Author

/test pull-tekton-pipeline-alpha-integration-tests

@chuangw6
Copy link
Member Author

/assign @ywluogg
/assign @dibyom

@tekton-robot
Copy link
Collaborator

@chuangw6: GitHub didn't allow me to assign the following users: ywluogg.

Note that only tektoncd members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

/assign @ywluogg
/assign @dibyom

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ywluogg
Copy link
Contributor

ywluogg commented Jun 21, 2022

/assign @ywluogg

@Yongxuanzhang Yongxuanzhang mentioned this pull request Jun 21, 2022
Merged
5 tasks
@chuangw6 chuangw6 force-pushed the pipelinerun-var-replacement branch from 4ceb2d8 to 6d29aeb Compare June 23, 2022 20:13
@tekton-robot tekton-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 23, 2022
@chuangw6 chuangw6 force-pushed the pipelinerun-var-replacement branch 2 times, most recently from 8143e5c to 33f8023 Compare June 23, 2022 20:17
@tekton-robot tekton-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 23, 2022
@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/pipeline/v1beta1/param_types.go 97.4% 97.9% 0.5

@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/pipeline/v1beta1/param_types.go 97.4% 97.9% 0.5

@ywluogg
Copy link
Contributor

ywluogg commented Jun 24, 2022

link back to #4723

@ywluogg
Copy link
Contributor

ywluogg commented Jun 24, 2022

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 24, 2022
@chuangw6 chuangw6 requested a review from dibyom June 27, 2022 14:07
dibyom
dibyom approved these changes Jun 28, 2022
View reviewed changes
pkg/apis/pipeline/v1beta1/param_types.go
return
}

// trim the head "$(" and the tail ")" or "[*])"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the comments are helpful :)

@tekton-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dibyom, ywluogg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 28, 2022
@chuangw6
Copy link
Member Author

/test tekton-pipeline-unit-tests

@Yongxuanzhang
Copy link
Member

/retest

@Yongxuanzhang
Copy link
Member

/retest pull-pipeline-kind-k8s-v1-21-e2e

@dibyom
Copy link
Member

dibyom commented Jun 29, 2022

/test pull-pipeline-kind-k8s-v1-21-e2e

@dibyom
Copy link
Member

dibyom commented Jun 29, 2022

/retest

@dibyom dibyom closed this Jun 29, 2022
@dibyom dibyom reopened this Jun 29, 2022
@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/pipeline/v1beta1/param_types.go 97.4% 97.9% 0.5

@chuangw6
Copy link
Member Author

/retest

1 similar comment
@chuangw6
Copy link
Member Author

/retest

@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/pipeline/v1beta1/param_types.go 97.4% 97.9% 0.5

@Yongxuanzhang
Copy link
Member

/retest

1 similar comment
@chuangw6
Copy link
Member Author

/retest

@dibyom
Copy link
Member

dibyom commented Jun 29, 2022

/test pull-tekton-pipeline-unit-tests

@chuangw6
Copy link
Member Author

/test pull-tekton-pipeline-build-tests
/test pull-tekton-pipeline-unit-tests

@chuangw6
Copy link
Member Author

/test pull-tekton-pipeline-unit-tests

@chuangw6
Copy link
Member Author

/retest

@tekton-robot tekton-robot merged commit 0cee557 into tektoncd:main Jun 29, 2022
jerop added a commit to jerop/pipeline that referenced this pull request Jun 29, 2022
@jerop
TEP-0075: Remove log statement
c6b45df 
Ran into this log statement when running tests - it was introduced
in tektoncd#5007 when debugging
TEP-0075 I believe. This change is cleaning up the log statement.
@jerop jerop mentioned this pull request Jun 29, 2022
Merged
3 tasks
tekton-robot pushed a commit that referenced this pull request Jun 30, 2022
@jerop @tekton-robot
TEP-0075: Remove log statement
c678fe1 
Ran into this log statement when running tests - it was introduced
in #5007 when debugging
TEP-0075 I believe. This change is cleaning up the log statement.
@Yongxuanzhang Yongxuanzhang mentioned this pull request Sep 27, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dibyom dibyom dibyom approved these changes

@ywluogg ywluogg ywluogg approved these changes

@afrittoli afrittoli Awaiting requested review from afrittoli

@jerop jerop Awaiting requested review from jerop

Assignees

@dibyom dibyom

@ywluogg ywluogg

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@chuangw6 @tekton-robot @ywluogg @Yongxuanzhang @dibyom