Remove deprecated TaskRun.Status.ResourceResults.ResourceRef field

[abayer]

Changes

See #2694.

The TaskRun.Status.ResourceResults.ResourceRef field was only ever used for its own Name field, and as part of #2694, a new field, TaskRun.Status.ResourceResults.ResourceName was added to replace ...ResourceRef.Name with a more semantically appropriate field. This change finishes the work by removing the deprecated TaskRun.Status.ResourceResults.ResourceRef.

This has been scheduled for removal since April 2021.

/kind cleanup

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

• Docs included if any changes are user facing
• Tests included if any functionality added or changed
• Follows the commit message standard
• Meets the Tekton contributor standards (including
  functionality, content, code)
• Release notes block below has been filled in
  (if there are no user facing changes, use release note "NONE")

Release Notes

Removes deprecated `TaskRun.Status.ResourceResults.ResourceRef` field; use `TaskRun.Status.ResourceResults.ResourceName` instead.

[abayer]

cc @lbernick

[abayer]

/assign @jerop @lbernick @pritidesai @vdemeester @afrittoli

[lbernick]

Thanks Andrew! Could you add a bit more context to the commit message and PR description (from the linked issue), stating that ResourceRef and ResourceName contain the same info but "resourceRef" doesn't make semantic sense? Also, you have a typo in the PR name (should be "deprecated")

[jerop]

@abayer this was deprecated a long time ago and is overdue for removal, but wondering if we should send out an email to tekton-dev@ and tekton-users@ about the removal in the next release just in case someone is still using it and needs to migrate off it before the next release?

[tekton-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jerop, lbernick

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [jerop,lbernick]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[abayer]

@lbernick Will do!

And @jerop, yup, an email will be needed.

[abayer]

@lbernick Done, I hope. =)

[abayer]

/retest

[abayer]

@lbernick @jerop Ok, should be good and ready for an lgtm, hopefully!

[jerop]

🎉

/lgtm

[afrittoli]

It looks like, even if not used, resourceRef was set in the status, and now the webhook does not allow deleting resources with a resourceRef:

    request-pr-docs-reviewer-wjfgm-clone-repo:
      pipelineTaskName: clone-repo
      status:
        completionTime: "2022-07-04T08:57:17Z"
        conditions:
        - lastTransitionTime: "2022-07-04T08:57:17Z"
          message: All Steps have completed executing
          reason: Succeeded
          status: "True"
          type: Succeeded
        podName: request-pr-docs-reviewer-wjfgm-clone-repo-pod
        resourcesResult:
        - key: url
          resourceRef: {}
          value: https://github.com/tektoncd/pipeline

and

$ tkn pr delete request-pr-docs-reviewer-wjfgm -n tekton-ci
Are you sure you want to delete PipelineRun(s) "request-pr-docs-reviewer-wjfgm" (y/n): y
Error: failed to delete PipelineRun "request-pr-docs-reviewer-wjfgm": admission webhook "validation.webhook.pipeline.tekton.dev" denied the request: decoding request failed: cannot decode incoming old object: json: unknown field "resourceRef"

I filed #5317 to track the issue