Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix test cases for validatePipelineParameterVariables function #4901

Merged
merged 1 commit into from
Jun 9, 2022

Commits on May 23, 2022

  1. Fix test cases for validatePipelineParameterVariables function

    Prior to this commit, many success tests were meaningless because they
    just use the param names in the format of `$(baz)`, `$(foo-is-baz)`.
    In validation, without using the format of `$(params.<Name>)`, the
    two examples above will be treated as just string literal instead of param
    reference, and thus  in fact validation agains using correct params
    are not executed. That explains why there is no problem even though
    declared param is actually called `baz`, but using `$(bazzzz)`.
    
    In this commit, the usage of param names is corrected to `$(params.<Name>)`
    and type for ArrayOrString is added so that the param reference is really
    validated.
    chuangw6 committed May 23, 2022
    Configuration menu
    Copy the full SHA
    e51a1f1 View commit details
    Browse the repository at this point in the history